Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Draft 0.11.0 Umbrella #1312

Closed
12 of 14 tasks
flarnie opened this issue Jul 28, 2017 · 17 comments
Closed
12 of 14 tasks

Draft 0.11.0 Umbrella #1312

flarnie opened this issue Jul 28, 2017 · 17 comments
Assignees
Milestone

Comments

@flarnie
Copy link
Contributor

flarnie commented Jul 28, 2017

If you've followed the v0.10.0 migration guide then you're all set to try the alpha release of Draft 0.11.0!

Get this new and improved Draft.js by installing [email protected] or updating your package.json to the following and running yarn install/npm install:

  "draft-js": "0.11.0-alpha" 

And help make Draft better by reporting bugs. :)


Progress towards releasing Draft 0.11.0:

@stevewillard
Copy link

I noticed that the peerDependencies for 0.11.0 are:

  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.0-rc",
    "react-dom": "^0.14.0 || ^15.0.0-rc"
  },

Are there plans to also support ^16.0.0?

Thanks for the great work! 👍

@flarnie
Copy link
Contributor Author

flarnie commented Aug 4, 2017

Hi Steve!

Absolutely - thanks for the reminder. Should work without a hitch, since we have been using Draft.js with React 16-alpha internally for some time now.

@nodkz
Copy link

nodkz commented Aug 15, 2017

@flarnie if supported React 16, will be ref as string converted to function?

https://github.com/facebook/draft-js/blob/744e9b4eb4810797a93c66591fea6f9cac533b4b/src/component/base/DraftEditor.react.js#L243

With React 16.0.0-beta.5 I got such console error:
screen shot 2017-08-15 at 09 18 16

@flarnie
Copy link
Contributor Author

flarnie commented Aug 16, 2017

Edit: Of course, now that I think about it it makes sense that you are having this issue. Draft.js is requiring React 15 as a peer dependency, and if you also load React 16 then you'll have 2 copies of React loaded.

I would manually tweak the package.json of your copy of Draft.js to also accept React 16 as a peer dependency and then run npm install to see if that helps.


Hi @nodkz - I know that error is confusing, sorry about that. From what we have seen, it pretty much only happens when you have somehow loaded two copies of React. If you tell me more about your build system I might be able to help.

Here is an issue where other folks have talked through this same problem and we documented some cases and solutions:
#296

@nodkz
Copy link

nodkz commented Aug 16, 2017

@flarnie thanks for help!

Easiest way to make draft-js working with React 16

  • run before start/build shell command rm -fr ./node_modules/draft-js/node_modules/react-dom && rm -fr ./node_modules/draft-js/node_modules/react.
  • or shortly but with warning message if folders already removed rm -fr ./node_modules/draft-js/node_modules/react*

How I understood when I upgraded from React 15 to React 16-beta yarn copy old react version to the draft-js/node_modules for keeping peerDeps consistent. Also the same behavior if I remove node_modules and install packages from scratch. So adding react 16 in peerDeps will solve the problem with yarn.

PS. Ref as string is not a problem for React 16. All works like a charm.

@flarnie
Copy link
Contributor Author

flarnie commented Aug 28, 2017

Just an update - still blocked on "Update Facebook Draft uses to 0.11.0 API (for context see #839) - 29 remaining callsites need updated". Unfortunately I need someone within FB to work on those tasks and I'm mainly focused on React right now, so haven't churned through them yet. Thanks for everyone's patience.

@zth
Copy link

zth commented Jan 10, 2018

Hi!

Any news on this one? I'd really like to try out 0.11 as it solves a few annoyances for us (the main one being making the entity state fully immutable so updated entity data triggers a re-render properly) but I noticed the 0.11-alpha is quite far behind master. I guess this is still blocked due to FB needing to dedicate resources, but would it be feasible to merge master into the 0.11-alpha branch so we can test it, or does that not make sense?

Thank you in advance!

@dem
Copy link

dem commented Jan 25, 2018

Hi!
Thank you for cool project. We like it very much.

@flarnie Any updates on releasing v0.11 ?
We have similar problems with entity data updates in v0.10.x, mentioned by @zth

@flarnie
Copy link
Contributor Author

flarnie commented Jan 25, 2018

tldr; This is not on any team's roadmap and it's more work than I can do in my spare time, so no progress yet. Until someone within Facebook takes it on it likely won't progress. In about 5 months I may try championing this project again, but for now I'm booked working on other efforts. At that time I will recommend forking Draft internally, and we leave behind less vital uses of Draft.js without blocking progress of features for our main uses on Facebook and Messenger.

@Fi1osof
Copy link

Fi1osof commented Nov 18, 2018

@flarnie will the editor evolve or not? It makes sense to wait for a major release?
Thanks!

@desktp
Copy link

desktp commented Nov 26, 2018

@flarnie Sorry to bother, but it would be nice to have that information on the repo's README. We've adopted draftjs around March, as we figured it was still active, but I've just now found this information, after having to slog through a rather large amount of bugs.

@benmosher
Copy link

more recent update from @flarnie on another thread: #1193 (comment)

@benmosher
Copy link

I will start by admitting that I am no paragon of keeping open source projects up to date (see import-js/eslint-plugin-import#1249 😅) but it would be nice to get a prognosis update for the maintenance status of this project from the maintainer's perspective, particularly after the September update linked in my preceding comment.

Like others, I am trying to figure out after a little bit of time using (and enjoying!) this project whether I need to consider something else or forking to get the current master and fix other bugs I have encountered myself.

@claudiopro
Copy link
Contributor

Hi @benmosher, thanks for voicing the concerns that most users in the community are having. We are looking into reducing the bundle size after the addition of a new HTML converter which coexists with the old one. This is currently being dogfooded internally for regression and, since it caused a breakage in production earlier, we're being extra scrupulous with testing. We'll keep you updated on progress in this issue.

@hejtmii
Copy link

hejtmii commented Aug 14, 2019

Hi, what is the status of this? I can see the release of v0.11, but this issue is still open and checkboxes not checked. Were all the above tasks finished? E.g. can we rely on v0.11 being fully tested? I am also missing branch v0.11-stable, can we consider master as such?

@fabiomcosta
Copy link
Contributor

Yeah, I think we could just close this issue... the new releases are there...

@mrkev
Copy link
Contributor

mrkev commented Oct 3, 2020

v0.11.0 shipped, so closing this issue.

The removal of the global DraftEntity API did not make it to v0.11.0 and will instead happen in v0.12.0. Any follow-ups to that change can be posted on the v0.12.0 umbrella issue: #2650.

@mrkev mrkev closed this as completed Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests