__dirname is not defined in ES module scope

[wojtekmaj]

Report

• I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce

Import yoga-layout in an ESM project.

Expected Behavior

Yoga to be correctly imported.

Actual Behavior

__dirname is not defined in ES module scope

Note

It looks like it's the only issue that causes yoga-layout from working seamlessly in ESM environment.

[wojtekmaj]

Appears to be related: emscripten-core/emscripten#12184

[NickGerleman]

There's an upcoming change for the next major version of Yoga (releasing mid-feb), where we ended up making the JS bindings ES module compatible (and actually, only ES module compatible, for reasons around TLA and the future wasm module integration is going). ef1d772 is the commit that made that change.

This is not on the npmjs registry yet, and I still need to document that change when we do release notes, but I am fairly certain that would fix this issue (and will also break compat with CommonJS, unfortunately).

[NickGerleman]

Going to close this out, since I think it should be fixed by the upcoming release, but let me know otherwise.