Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move s-column constraint evaluation logic into the regular constraint evaluator #306

Closed
Al-Kindi-0 opened this issue Sep 2, 2024 · 1 comment
Closed

Move s-column constraint evaluation logic into the regular constraint evaluator #306

Al-Kindi-0 opened this issue Sep 2, 2024 · 1 comment

Comments

@Al-Kindi-0
Copy link
Contributor

Currently during constraint evaluation and when LogUp-GKR is enabled, we are reading both main and aux frames twice from the trace LDE: the first time during regular constraint evaluation and the second time during S-column constraint evaluation.

An alternative approach could be to move S column evaluation logic into the regular constraint evaluator.

Originally posted by @irakliyk in #297 (comment)
@Al-Kindi-0 Al-Kindi-0 mentioned this issue Sep 16, 2024
Merged
@Al-Kindi-0
Copy link
Contributor Author

Done as part of #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Al-Kindi-0