Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch a panic in merkle proof verification #201

Closed
themighty1 opened this issue May 17, 2023 · 1 comment
Closed

catch a panic in merkle proof verification #201

themighty1 opened this issue May 17, 2023 · 1 comment

Comments

@themighty1
Copy link

Currently, there is a panic in winterfell's crypto crate when verifying a Merkle proof, see #200
The lib assumes that the prover honestly informs the verifier about the total amount of leaves in the tree as well as the leaf indices being proved.

The same type of assumption and panics are present in other merkle libs:
antouhou/rs-merkle#20
https://github.com/rozbb/ct-merkle/blob/e29d123e1b45b0e652e5ee5e4c288ff3792652e5/src/batch_inclusion.rs#L404

Until this issue is fixed upstream, we should wrap the verification in panic::catch_unwind.

@themighty1
Copy link
Author

oops, opened this issue under the wrong project, sry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant