Skip to content

Commit 3afec73

Browse files
committed
wip: avoid extra allocation when projecting mle
1 parent 6283109 commit 3afec73

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

prover/src/logup_gkr/prover.rs

+9-13
Original file line numberDiff line numberDiff line change
@@ -190,18 +190,16 @@ fn prove_intermediate_layers<
190190

191191
// construct the vector of multi-linear polynomials
192192
// TODO: avoid unnecessary allocation
193-
let (mut left_numerators, mut right_numerators) =
194-
inner_layer.numerators.project_least_significant_variable();
195-
let (mut left_denominators, mut right_denominators) =
196-
inner_layer.denominators.project_least_significant_variable();
193+
//let (mut left_numerators, mut right_numerators) =
194+
//inner_layer.numerators.project_least_significant_variable();
195+
//let (mut left_denominators, mut right_denominators) =
196+
//inner_layer.denominators.project_least_significant_variable();
197197

198198
// run the sumcheck protocol
199199
let proof = sum_check_prove_num_rounds_degree_3(
200200
claimed_evaluation,
201-
&mut left_numerators,
202-
&mut right_numerators,
203-
&mut left_denominators,
204-
&mut right_denominators,
201+
&inner_layer.numerators,
202+
&inner_layer.denominators,
205203
&mut eq_mle,
206204
transcript,
207205
)?;
@@ -251,10 +249,8 @@ fn sum_check_prove_num_rounds_degree_3<
251249
H: ElementHasher<BaseField = E::BaseField>,
252250
>(
253251
claim: (E, E),
254-
p0: &mut MultiLinearPoly<E>,
255-
p1: &mut MultiLinearPoly<E>,
256-
q0: &mut MultiLinearPoly<E>,
257-
q1: &mut MultiLinearPoly<E>,
252+
p: & MultiLinearPoly<E>,
253+
q: & MultiLinearPoly<E>,
258254
eq: &mut MultiLinearPoly<E>,
259255
transcript: &mut C,
260256
) -> Result<SumCheckProof<E>, GkrProverError> {
@@ -263,7 +259,7 @@ fn sum_check_prove_num_rounds_degree_3<
263259
let r_batch = transcript.draw().map_err(|_| GkrProverError::FailedToGenerateChallenge)?;
264260
let claim_ = claim.0 + claim.1 * r_batch;
265261

266-
let proof = sumcheck_prove_plain(claim_, r_batch, p0, p1, q0, q1, eq, transcript)?;
262+
let proof = sumcheck_prove_plain(claim_, r_batch, p, q, eq, transcript)?;
267263

268264
Ok(proof)
269265
}

0 commit comments

Comments
 (0)