Skip to content

Commit 601a6b5

Browse files
hx235facebook-github-bot
authored andcommitted
Temporarily disable track_and_verify_wals with write related injection (#13263)
Summary: **Context/Summary:** After #13226, our crash test appears to find a WAL hole caused by mishandling of an injected error during writing the buffer in writable file writer into the underlying log file. It will take some time for me to fully root-cause and fix it. Before then, let's disable this combination. Pull Request resolved: #13263 Test Plan: Monitor crash test Reviewed By: ltamasi Differential Revision: D67755485 Pulled By: hx235 fbshipit-source-id: 5f7bb422f7722c2696872232b1fed8ffa5c0f4c3
1 parent 159fa77 commit 601a6b5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tools/db_crashtest.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -1011,7 +1011,11 @@ def finalize_and_sanitize(src_params):
10111011
dest_params["use_full_merge_v1"] = 0
10121012
dest_params["enable_pipelined_write"] = 0
10131013
dest_params["use_attribute_group"] = 0
1014-
1014+
# TODO(hx235): Enable below fault injections again after resolving the apparent WAL hole
1015+
# that the mishandling of these faults create and is detected by `track_and_verify_wals=0`
1016+
if dest_params.get("track_and_verify_wals", 0) == 1:
1017+
dest_params["metadata_write_fault_one_in"] = 0
1018+
dest_params["write_fault_one_in"] = 0
10151019
return dest_params
10161020

10171021

0 commit comments

Comments
 (0)