Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docblock parser doesn't handle CRLF #4864

Open
sverrejoh opened this issue Dec 12, 2024 · 0 comments · May be fixed by #4865
Open

Docblock parser doesn't handle CRLF #4864

sverrejoh opened this issue Dec 12, 2024 · 0 comments · May be fixed by #4865

Comments

@sverrejoh
Copy link
Contributor

sverrejoh commented Dec 12, 2024 •
edited
Loading

Windows newlines (CRLF) doesn't work in dockblocks

Source code with the Windows CRLF line endings breaks the Dockblock parser as it doesn't handle CRLF and expects UNIX style \n newlines. This causes the \r character to be part of the identifier which triggers errors like unknown identifier or it detects '\r' as an argument.
@sverrejoh sverrejoh changed the title Docblock parser doesn Docblock parser doesn't handle CRLF Dec 12, 2024
@sverrejoh sverrejoh linked a pull request Dec 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle CRLF when parsing docblocks sverrejoh/relay
1 participant
@sverrejoh