This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
runtime: Use [[Define]] for the Symbol.toStringTag property
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
force-pushed
the
fix/use-define-for-tostringtag
branch
from
68600b4 to
ea5c013
Compare
benjamn
reviewed
Jul 22, 2020
ExE-Boss
force-pushed
the
fix/use-define-for-tostringtag
branch
from
ea5c013 to
980ca64
Compare
|
@ExE-Boss Can you open that repo/branch for me to push? Also happy to merge and then make my own tweaks. |
ljharb
approved these changes
Jul 22, 2020
|
@ExE-Boss Ahh I missed that. Pushed (above)! |
ljharb
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #400 makes it so that once engines start shipping
Iterator.prototype[Symbol.toStringTag], thenObject.prototype.toStringwill return[object Iterator]instead of[object Generator]for regenerator’s generator objects.This fixes that to ensure that it doesn’t happen.