Vendor OCaml Migrate ParseTree. #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Problem: There exists reason packages in the wild that have `omp: *` as a dependency. A new breaking change was released in omp 2.0.0. We cannot compile against it. We also cannot upgrade to the intended replacement for the old functionality we were using `ppxlib` because it doesn't support older versions of omp. The only solution is to vendor. This should unbreak existing libraries that depend on older versions of Reason. We should have had a constraint of `omp: < 2.0.0`, but even in that case the package ecosystem essentially breaks because it splits into two sides - ones that can use 2.0.0 omp and ones that cannot. Vendoring omp solves that problem. It might not work during the next compiler upgrade though (estimated six months). Test Plan: Reviewers: CC:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Problem: There exists reason packages in the wild that have
omp: *as adependency. A new breaking change was released in omp 2.0.0. We cannot
compile against it. We also cannot upgrade to the intended replacement
for the old functionality we were using
ppxlibbecause it doesn'tsupport older versions of omp.
The only solution is to vendor. This should unbreak existing libraries
that depend on older versions of Reason.
We should have had a constraint of
omp: < 2.0.0, but even in that casethe package ecosystem essentially breaks because it splits into two
sides - ones that can use 2.0.0 omp and ones that cannot. Vendoring omp
solves that problem. It might not work during the next compiler upgrade
though (estimated six months).
Test Plan:
Reviewers:
CC: