Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beautiful printing of Pexp_function expressions as jsx props #2024

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Beautiful printing of Pexp_function expressions as jsx props #2024

merged 1 commit into from
Jun 25, 2018

Conversation

IwanKaramazow
Copy link
Contributor

Fixes #2023

/* Before */
<Component
  accept=(
           fun
           | Foo => true
           | Bar => false
         )
/>

/* After */
<Component
  accept=(
    fun
    | Foo => true
    | Bar => false
  )
/>

@IwanKaramazow IwanKaramazow mentioned this pull request Jun 24, 2018
Closed
@chenglou
Copy link
Member

Guess so, but we don’t encourage fun cases currently

@chenglou chenglou merged commit a4f4ea8 into reasonml:master Jun 25, 2018
@chenglou
Copy link
Member

chenglou commented Jun 25, 2018 •
edited
Loading

But if we do support it it should at least be good. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IwanKaramazow @chenglou @facebook-github-bot