Don't swallow <> </> fragments when formatting
#1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self#formatChildren (remaining @ children) processedRev | ||
| | {pexp_desc = Pexp_construct ({txt = Lident "::"}, Some {pexp_desc = Pexp_tuple children} )} as x :: remaining -> | ||
| let {jsxAttrs} = partitionAttributes x.pexp_attributes in | ||
| if jsxAttrs != [] then |
There was a problem hiding this comment.
Another option is the pattern match on jsxAttrs. Pattern matching is probably cheaper than physical equality checks. (Correct me if I'm wrong).
There was a problem hiding this comment.
Pattern matching should be safer against future changes in compiler optimizations around equality.
There was a problem hiding this comment.
Hah, I actually had a pattern match at first but decided to go with this approach given it’s used everywhere else that does the same thing.
|
Can you add some extra tests to verify other expressions? |
|
Addressed the comments in the new commits. |
|
Great! @chenglou, good from my part |
|
Thanks. Will be useful soon I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #870