Fix parsing & printing of es6 function syntax inside attribrutes #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inside a payload (attribute).
chenglou
reviewed
May 18, 2018
src/reason-parser/reason_lexer.mll
Outdated
| @@ -919,6 +919,7 @@ and skip_sharp_bang = parse | |||
|
|
|||
| let inject_es6_fun = function | |||
| | tok :: acc -> | |||
| print_endline "INJECTING"; | |||
There was a problem hiding this comment.
forgot to rebase lol
hcarty
reviewed
May 18, 2018
src/reason-parser/reason_lexer.mll
Outdated
| @@ -919,6 +919,7 @@ and skip_sharp_bang = parse | |||
|
|
|||
| let inject_es6_fun = function | |||
| | tok :: acc -> | |||
| print_endline "INJECTING"; | |||
There was a problem hiding this comment.
Forgot to remove it 💃
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
May 18, 2018
One extra fix from reasonml/reason#1943. Helps bs.raw functions sugar
|
I think I ended up having a good use case for this one. Glad to see this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937
Fixes #1902