Consider two adjacent comments at end of line to both be EOL comments. #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwalke
force-pushed
the
AdjacentEOLComments
branch
6 times, most recently
from
a36eed4
to
46d70e1
Compare
Summary: For the sake of formatting logic, they should be treated the same. Test Plan: Reviewers: CC:
jordwalke
force-pushed
the
AdjacentEOLComments
branch
from
46d70e1
to
ba3631a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of formatting logic, they should be treated the same.
This comes in handy when doing trailing commas as well as removing some over-abstractions from the printer. Diffs coming soon.