Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pun record destructuring with renaming #1517

Merged
merged 1 commit into from
Oct 16, 2017
Merged

pun record destructuring with renaming #1517

merged 1 commit into from
Oct 16, 2017

Conversation

IwanKaramazow
Copy link
Contributor

@IwanKaramazow IwanKaramazow commented Oct 16, 2017 •
edited by chenglou
Loading

Fixes #1320

/* before */
let x = ({ReasonReact.state: state as prevState}) => 1;
let x = ({state: state as prevState}) => 1;

/* after */
let x = ({ReasonReact.state as prevState}) => 1;
let x = ({state as prevState}) => 1;

@chenglou
Copy link
Member

Thanks!

@chenglou chenglou merged commit eeb75d4 into reasonml:master Oct 16, 2017
chenglou added a commit that referenced this pull request Oct 16, 2017
@chenglou
[Docs] #1517
dc12a1e
@jordwalke
Copy link
Member

Nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IwanKaramazow @chenglou @jordwalke @facebook-github-bot