Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Don't call componentDidUpdate if shouldComponentUpdate returns false #8028

Merged
merged 1 commit into from
Oct 25, 2016
Merged

[Fiber] Don't call componentDidUpdate if shouldComponentUpdate returns false #8028

merged 1 commit into from
Oct 25, 2016

Commits on Oct 25, 2016

  1. Don't call componentDidUpdate if shouldComponentUpdate returns false 

    This fix relies on the props and state objects being different
to know if we can avoid a componentDidUpdate. This is not a great
solution because we actually want to use the new props/state
object even if sCU returns false. That's the current semantics
and it can actually be important because new rerenders that are
able to reuse props objects are more likely to have the new props
object so we won't be able to quickly bail out next time.
I don't have a better idea atm though.
    @sebmarkbage
    sebmarkbage committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    46bde58 View commit details
    Browse the repository at this point in the history