Skip to content

[tests] disableLegacyMode in test-renderer #35002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

[tests] disableLegacyMode in test-renderer #35002

merged 1 commit into from
Oct 28, 2025

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Oct 28, 2025

500 tests failed from not using async act. Will fix the tests and then re-land this.

@meta-cla meta-cla bot added the CLA Signed label Oct 28, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 28, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 28, 2025

Comparing: b4455a6...fc76c12

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 605.41 kB 605.41 kB = 107.22 kB 107.22 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 664.38 kB 664.38 kB = 117.09 kB 117.09 kB
facebook-www/ReactDOM-prod.classic.js = 688.25 kB 688.25 kB = 121.13 kB 121.13 kB
facebook-www/ReactDOM-prod.modern.js = 678.67 kB 678.67 kB = 119.48 kB 119.49 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +2.03% 603.76 kB 615.98 kB +1.67% 96.99 kB 98.61 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +2.03% 603.76 kB 615.98 kB +1.67% 96.99 kB 98.61 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +1.98% 362.19 kB 369.36 kB +1.86% 62.13 kB 63.29 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +1.95% 337.97 kB 344.56 kB +2.00% 58.76 kB 59.93 kB

Generated by 🚫 dangerJS against fc76c12

@rickhanlonii rickhanlonii merged commit fb0d960 into facebook:main Oct 28, 2025
246 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
@rickhanlonii
[tests] disableLegacyMode in test-renderer (#35002)
99c8e7c 
500 tests failed from not using async act. Will fix the tests and then
re-land this.

DiffTrain build for [fb0d960](fb0d960)
@nextjs-bot nextjs-bot mentioned this pull request Oct 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poteto poteto poteto approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickhanlonii @react-sizebot @poteto