From 4c19d18ec0fee2d09db34a4da0ab3a7a2a40501a Mon Sep 17 00:00:00 2001 From: Sebastian Sebbie Silbermann Date: Mon, 25 Aug 2025 16:29:20 +0200 Subject: [PATCH] [DevTools] Avoid tearing Suspense store --- .../src/devtools/views/SuspenseTab/SuspenseRects.js | 2 +- .../src/devtools/views/SuspenseTab/SuspenseTreeContext.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js b/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js index 65fa4dec073..b1c30a32300 100644 --- a/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js +++ b/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js @@ -55,7 +55,7 @@ function SuspenseRects({ const suspense = store.getSuspenseByID(suspenseID); if (suspense === null) { - console.warn(` Could not find suspense node id ${suspenseID}`); + // getSuspenseByID will have already warned return null; } diff --git a/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js b/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js index a16c93a4573..42f903ae09b 100644 --- a/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js +++ b/packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js @@ -81,7 +81,7 @@ function SuspenseTreeContextController({children}: Props): React.Node { useEffect(() => { const handleSuspenseTreeMutated = () => { - transitionDispatch({ + dispatch({ type: 'HANDLE_SUSPENSE_TREE_MUTATION', }); }; @@ -91,7 +91,7 @@ function SuspenseTreeContextController({children}: Props): React.Node { // At the moment, we can treat this as a mutation. // We don't know which Elements were newly added/removed, but that should be okay in this case. // It would only impact the search state, which is unlikely to exist yet at this point. - transitionDispatch({ + dispatch({ type: 'HANDLE_SUSPENSE_TREE_MUTATION', }); }