Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Mar 14, 2025

Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.

@react-sizebot
Copy link

react-sizebot commented Mar 14, 2025

Comparing: 4eba294...ddba0cd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.75 kB 518.75 kB = 92.46 kB 92.46 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 591.76 kB 591.76 kB = 105.36 kB 105.36 kB
facebook-www/ReactDOM-prod.classic.js = 652.39 kB 652.39 kB = 114.72 kB 114.72 kB
facebook-www/ReactDOM-prod.modern.js = 642.71 kB 642.71 kB = 113.15 kB 113.15 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e4225b1

@poteto poteto changed the title [ci] Bust all caches [ci] Update node_modules cache path Mar 14, 2025
poteto added a commit that referenced this pull request Mar 14, 2025
This reverts commit ef1103d.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32606).
* #32609
* #32608
* #32607
* __->__ #32606
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
This reverts commit ef1103d.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32606).
* #32609
* #32608
* #32607
* __->__ #32606

DiffTrain build for [e9d80d9](e9d80d9)
poteto added a commit that referenced this pull request Mar 14, 2025
This reverts commit 6733870.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32607).
* #32609
* #32608
* __->__ #32607
poteto added a commit that referenced this pull request Mar 14, 2025
We only need the compiler built for `yarn test` in the root directory.
Rather than always cache both for every step, let's just do it where
it's needed explicitly.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32608).
* #32609
* __->__ #32608
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
This reverts commit 6733870.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32607).
* #32609
* #32608
* __->__ #32607

DiffTrain build for [5200721](5200721)
Alternative of #32604.

Bust all old caches since I reverted some other changes to the keys.
@poteto poteto merged commit f3c9560 into main Mar 14, 2025
205 checks passed
@poteto poteto deleted the pr32609 branch March 14, 2025 02:29
github-actions bot pushed a commit to PrivAtlas/react that referenced this pull request Mar 14, 2025
Alternative of facebook#32604.

Bust all old caches since I reverted some other changes to the keys.

DiffTrain build for [f3c9560](facebook@f3c9560)
github-actions bot pushed a commit to PrivAtlas/react that referenced this pull request Mar 14, 2025
Alternative of facebook#32604.

Bust all old caches since I reverted some other changes to the keys.

DiffTrain build for [f3c9560](facebook@f3c9560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants