[compiler] Repro for object spread and Array.from with mutable iterators #32520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See newly added test fixtures. Repros fixed in later prs of this stack
This was referenced Mar 4, 2025
github-actions
bot
added
the
React Core Team
josephsavona
reviewed
Mar 6, 2025
|
|
||
| /** | ||
| * TODO fixture for granular iterator semantics: | ||
| * 1. ConditionallyMutate the iterator itself, depending on whether the iterator |
Member
There was a problem hiding this comment.
there's no iterator in this example?
josephsavona
reviewed
Mar 6, 2025
Comment on lines
+17
to
+25
| /** | ||
| * Note that mutableIterator is mutated by the later object spread. Therefore, | ||
| * `s.values()` should be memoized within the same block as the object spread. | ||
| * In terms of compiler internals, they should have the same reactive scope. | ||
| */ | ||
| const s = new Set([1, 5, 4]); | ||
| const mutableIterator = s.values(); | ||
|
|
||
| return [arg, ...mutableIterator]; |
josephsavona
approved these changes
Mar 6, 2025
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See newly added test fixtures. Repros fixed in later prs of this stack
Stack created with Sapling. Best reviewed with ReviewStack.