From 7d479189e6a2e8f56c89c45464a556b21e6f14cc Mon Sep 17 00:00:00 2001
From: Josh Story <story@hey.com>
Date: Mon, 8 Apr 2024 15:15:39 -0700
Subject: [PATCH] [DOM] disallow client entrypoints with react-server condition

`react-server` precludes loading code that expects to be run in a client context. This includes react-dom/client react-dom/server react-dom/unstable_testing react-dom/profiling and react-dom/static

This update makes importing any of these client only entrypoints an error
---
 packages/react-dom/npm/client.react-server.js |  5 ++
 .../react-dom/npm/profiling.react-server.js   |  5 ++
 packages/react-dom/npm/server.react-server.js |  5 ++
 packages/react-dom/npm/static.react-server.js |  5 ++
 .../npm/unstable_testing.react-server.js      |  5 ++
 packages/react-dom/package.json               | 52 +++++++++++++++----
 6 files changed, 67 insertions(+), 10 deletions(-)
 create mode 100644 packages/react-dom/npm/client.react-server.js
 create mode 100644 packages/react-dom/npm/profiling.react-server.js
 create mode 100644 packages/react-dom/npm/server.react-server.js
 create mode 100644 packages/react-dom/npm/static.react-server.js
 create mode 100644 packages/react-dom/npm/unstable_testing.react-server.js

diff --git a/packages/react-dom/npm/client.react-server.js b/packages/react-dom/npm/client.react-server.js
new file mode 100644
index 00000000000..a00f3d9b6cf
--- /dev/null
+++ b/packages/react-dom/npm/client.react-server.js
@@ -0,0 +1,5 @@
+'use strict';
+
+throw new Error(
+  'react-dom/client is not supported in React Server Components.'
+);
diff --git a/packages/react-dom/npm/profiling.react-server.js b/packages/react-dom/npm/profiling.react-server.js
new file mode 100644
index 00000000000..434474e4215
--- /dev/null
+++ b/packages/react-dom/npm/profiling.react-server.js
@@ -0,0 +1,5 @@
+'use strict';
+
+throw new Error(
+  'react-dom/profiling is not supported in React Server Components.'
+);
diff --git a/packages/react-dom/npm/server.react-server.js b/packages/react-dom/npm/server.react-server.js
new file mode 100644
index 00000000000..4126b4f9e3d
--- /dev/null
+++ b/packages/react-dom/npm/server.react-server.js
@@ -0,0 +1,5 @@
+'use strict';
+
+throw new Error(
+  'react-dom/server is not supported in React Server Components.'
+);
diff --git a/packages/react-dom/npm/static.react-server.js b/packages/react-dom/npm/static.react-server.js
new file mode 100644
index 00000000000..8325d617706
--- /dev/null
+++ b/packages/react-dom/npm/static.react-server.js
@@ -0,0 +1,5 @@
+'use strict';
+
+throw new Error(
+  'react-dom/static is not supported in React Server Components.'
+);
diff --git a/packages/react-dom/npm/unstable_testing.react-server.js b/packages/react-dom/npm/unstable_testing.react-server.js
new file mode 100644
index 00000000000..e2611f10f25
--- /dev/null
+++ b/packages/react-dom/npm/unstable_testing.react-server.js
@@ -0,0 +1,5 @@
+'use strict';
+
+throw new Error(
+  'react-dom/unstable_testing is not supported in React Server Components.'
+);
diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json
index 5547c20de65..d750c5f2659 100644
--- a/packages/react-dom/package.json
+++ b/packages/react-dom/package.json
@@ -50,8 +50,12 @@
       "react-server": "./react-dom.react-server.js",
       "default": "./index.js"
     },
-    "./client": "./client.js",
+    "./client": {
+      "react-server": "./client.react-server.js",
+      "default": "./client.js"
+    },
     "./server": {
+      "react-server": "./server.react-server.js",
       "workerd": "./server.edge.js",
       "bun": "./server.bun.js",
       "deno": "./server.browser.js",
@@ -61,11 +65,24 @@
       "edge-light": "./server.edge.js",
       "default": "./server.node.js"
     },
-    "./server.browser": "./server.browser.js",
-    "./server.bun": "./server.bun.js",
-    "./server.edge": "./server.edge.js",
-    "./server.node": "./server.node.js",
+    "./server.browser": {
+      "react-server": "./server.react-server.js",
+      "default": "./server.browser.js"
+    },
+    "./server.bun": {
+      "react-server": "./server.react-server.js",
+      "default": "./server.bun.js"
+    },
+    "./server.edge": {
+      "react-server": "./server.react-server.js",
+      "default": "./server.edge.js"
+    },
+    "./server.node": {
+      "react-server": "./server.react-server.js",
+      "default": "./server.node.js"
+    },
     "./static": {
+      "react-server": "./static.react-server.js",
       "workerd": "./static.edge.js",
       "deno": "./static.browser.js",
       "worker": "./static.browser.js",
@@ -74,13 +91,28 @@
       "edge-light": "./static.edge.js",
       "default": "./static.node.js"
     },
-    "./static.browser": "./static.browser.js",
-    "./static.edge": "./static.edge.js",
-    "./static.node": "./static.node.js",
+    "./static.browser": {
+      "react-server": "./static.react-server.js",
+      "default": "./static.browser.js"
+    },
+    "./static.edge": {
+      "react-server": "./static.react-server.js",
+      "default": "./static.edge.js"
+    },
+    "./static.node": {
+      "react-server": "./static.react-server.js",
+      "default": "./static.node.js"
+    },
     "./server-rendering-stub": "./server-rendering-stub.js",
-    "./profiling": "./profiling.js",
+    "./profiling": {
+      "react-server": "./profiling.react-server.js",
+      "default": "./profiling.js"
+    },
     "./test-utils": "./test-utils.js",
-    "./unstable_testing": "./unstable_testing.js",
+    "./unstable_testing": {
+      "react-server": "./unstable_testing.react-server.js",
+      "default": "./unstable_testing.js"
+    },
     "./unstable_server-external-runtime": "./unstable_server-external-runtime.js",
     "./src/*": "./src/*",
     "./package.json": "./package.json"