Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow upgrade to 0.182 #25419

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Flow upgrade to 0.182 #25419

merged 2 commits into from
Oct 4, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022 •
edited
Loading

@kassens
Flow upgrade to 0.182
7bad0bb 
[ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
Merged
Closed
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2022
kassens added a commit to kassens/react that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.182
21db9fa 
ghstack-source-id: 58e651c26e8b5f878bf2d6a830d3929b5eaad928
Pull Request resolved: facebook#25419
gaearon
gaearon reviewed Oct 4, 2022
View reviewed changes
packages/react-devtools-shared/src/config/DevToolsFeatureFlags.core-fb.js
type Check<_X, Y: _X, X: Y = _X> = null;
// eslint-disable-next-line no-unused-expressions
(null: Check<ExportsType, FeatureFlagsType>);
// Flow magic to verify the exports of this file match the original version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified this still does what it's supposed to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed one export type and it showed an error.

The idea is that A can be casted into B and B can be casted into A, which I think implies that A = B.

kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.182
77afce6 
ghstack-source-id: b9bb8c1560e8ac6baf424deea2015c00629fb353
Pull Request resolved: #25419
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 3fd9bd8...4e55da6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-experimental/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-stable-semver/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-stable/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +3.41% 4.77 kB 4.94 kB +0.98% 1.73 kB 1.75 kB
oss-experimental/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-stable-semver/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-stable/react-pg/cjs/react-pg.node.development.server.js +2.98% 2.88 kB 2.97 kB +4.30% 1.16 kB 1.21 kB
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +2.18% 4.04 kB 4.13 kB +2.95% 1.22 kB 1.26 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +1.98% 64.87 kB 66.15 kB +0.38% 16.64 kB 16.70 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +1.98% 64.92 kB 66.21 kB +0.38% 16.65 kB 16.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +1.66% 77.59 kB 78.87 kB +0.34% 20.12 kB 20.18 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +1.66% 77.59 kB 78.87 kB +0.34% 20.12 kB 20.18 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +1.63% 79.02 kB 80.30 kB +0.35% 20.24 kB 20.31 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +1.63% 79.02 kB 80.30 kB +0.35% 20.24 kB 20.31 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +1.61% 81.46 kB 82.77 kB +0.27% 20.36 kB 20.42 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +1.61% 81.46 kB 82.77 kB +0.27% 20.36 kB 20.42 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +1.58% 81.58 kB 82.86 kB +0.36% 21.10 kB 21.18 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +1.55% 83.01 kB 84.29 kB +0.38% 21.23 kB 21.31 kB
oss-experimental/react-fetch/cjs/react-fetch.node.development.js +1.55% 5.69 kB 5.78 kB +2.13% 1.69 kB 1.72 kB
oss-stable-semver/react-fetch/cjs/react-fetch.node.development.js +1.55% 5.69 kB 5.78 kB +2.13% 1.69 kB 1.72 kB
oss-stable/react-fetch/cjs/react-fetch.node.development.js +1.55% 5.69 kB 5.78 kB +2.13% 1.69 kB 1.72 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +1.53% 85.65 kB 86.96 kB +0.27% 21.36 kB 21.42 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.46% 278.69 kB 279.97 kB +0.11% 66.65 kB 66.72 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.46% 278.71 kB 280.00 kB +0.11% 66.67 kB 66.74 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.46% 279.04 kB 280.33 kB +0.10% 67.19 kB 67.26 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.46% 279.07 kB 280.35 kB +0.10% 67.21 kB 67.28 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.46% 280.31 kB 281.59 kB +0.11% 67.15 kB 67.22 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.46% 280.33 kB 281.62 kB +0.11% 67.17 kB 67.25 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +0.46% 280.40 kB 281.68 kB +0.11% 67.11 kB 67.19 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +0.46% 280.42 kB 281.71 kB +0.11% 67.14 kB 67.21 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.45% 285.82 kB 287.11 kB +0.09% 67.39 kB 67.45 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js +0.45% 292.17 kB 293.47 kB +0.09% 67.34 kB 67.40 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js +0.45% 292.19 kB 293.50 kB +0.09% 67.36 kB 67.43 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js +0.45% 292.52 kB 293.83 kB +0.10% 67.87 kB 67.93 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js +0.45% 292.54 kB 293.85 kB +0.10% 67.89 kB 67.95 kB
facebook-www/ReactDOMServer-dev.modern.js +0.44% 290.32 kB 291.60 kB +0.09% 68.40 kB 68.47 kB
facebook-www/ReactDOMServer-dev.classic.js +0.43% 297.01 kB 298.30 kB +0.09% 69.88 kB 69.94 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.development.js +0.43% 300.20 kB 301.49 kB +0.10% 71.48 kB 71.55 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.43% 300.89 kB 302.18 kB +0.10% 71.67 kB 71.74 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.43% 301.92 kB 303.21 kB +0.11% 71.61 kB 71.68 kB
oss-experimental/react-dom/cjs/react-dom-static.node.development.js +0.43% 302.12 kB 303.40 kB +0.11% 71.72 kB 71.80 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.43% 302.16 kB 303.44 kB +0.11% 71.63 kB 71.71 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.42% 303.63 kB 304.92 kB +0.10% 72.07 kB 72.14 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.41% 315.52 kB 316.83 kB +0.10% 72.42 kB 72.49 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js +0.41% 316.57 kB 317.88 kB +0.09% 72.38 kB 72.45 kB

Generated by 🚫 dangerJS against 4e55da6

@kassens kassens merged commit 4e55da6 into gh/kassens/4/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.182
f02a5f5 
ghstack-source-id: b9bb8c1560e8ac6baf424deea2015c00629fb353
Pull Request resolved: #25419
@kassens kassens deleted the gh/kassens/4/head branch October 4, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @sizebot @gaearon @facebook-github-bot