Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the wrong renderer's act() should warn #15399

Commits on Apr 3, 2019

  1. Configuration menu
    Copy the full SHA
    c35e37a View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/master'

    Sunil Pai committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    dc605c1 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master'

    Sunil Pai committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    a09bd0f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Merge remote-tracking branch 'upstream/master'

    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    48ffcee View commit details
    Browse the repository at this point in the history
  2. warn when using the wrong act() around create/updates

    via facebook#15319
    This solves 2 specific problems -
    - using the 'wrong' act() doesn't silence the warning
    - using the wrong act logs a warning
    
    It does this by using an empty object on the reconciler as the identity of ReactShouldWarnActingUpdates.current. We also add this check when calling createContainer() to catch the common failure of this happening right in the beginning.
    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f0c3493 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master' into renderer-specific…

    …-act-warning
    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    c1e2986 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. make a proper fixture for act()

    made fixtures/act for act(). specifically, this lets us tests how act behaves when you use the wrong act() for the wrong renderer. also mvoes dom/../act-dom.html to this fixture.
    Sunil Pai committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    bd31fed View commit details
    Browse the repository at this point in the history
  2. cleanup fixtures/dom/.gitignore

    Sunil Pai committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    b417644 View commit details
    Browse the repository at this point in the history
  3. verify that it 'works' with art+dom

    Sunil Pai committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    6812f6e View commit details
    Browse the repository at this point in the history
  4. verify that it 'works' with art+test

    Sunil Pai committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    190f656 View commit details
    Browse the repository at this point in the history
  5. augh prettier

    Sunil Pai committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    7caa1b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. tweak warning messages

    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    4fc4c39 View commit details
    Browse the repository at this point in the history
  2. Stop tracking bundle sizes (facebook#15404)

    * [sizebot] Fail gracefully if CI returns invalid response
    
    Moves the `response.json()` call into the catch block.
    
    * Stop tracking bundle sizes
    acdlite authored and Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    91c5d79 View commit details
    Browse the repository at this point in the history
  3. React events: ignore device buttons that aren't for primary interacti…

    …ons (facebook#15402)
    
    The Pointer Events spec mentions that the value of `button` in a nativeEvent
    can be anything between 0 and 5 for "down" events. We only care about those
    with a value of 0.
    necolas authored and Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    46a4237 View commit details
    Browse the repository at this point in the history
  4. warn when using the wrong act() around create/updates

    via facebook#15319
    This solves 2 specific problems -
    - using the 'wrong' act() doesn't silence the warning
    - using the wrong act logs a warning
    
    It does this by using an empty object on the reconciler as the identity of ReactShouldWarnActingUpdates.current. We also add this check when calling createContainer() to catch the common failure of this happening right in the beginning.
    
    make a proper fixture for act()
    
    made fixtures/act for act(). specifically, this lets us tests how act behaves when you use the wrong act() for the wrong renderer. also mvoes dom/../act-dom.html to this fixture.
    
    cleanup fixtures/dom/.gitignore
    
    verify that it 'works' with art+dom
    
    verify that it 'works' with art+test
    
    augh prettier
    
    tweak warning messages
    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    e4d93a7 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'renderer-specific-act-warning' of github.com:threepoint…

    …one/react into renderer-specific-act-warning
    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    da0e642 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'upstream/master' into renderer-specific…

    …-act-warning
    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    d008007 View commit details
    Browse the repository at this point in the history
  7. lose ReactActingUpdatesSigil.js, use flushPassiveEffects as the actin…

    …g sigil
    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    0aebde1 View commit details
    Browse the repository at this point in the history
  8. copy nit

    Sunil Pai committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    7f3fd8f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Update ReactShouldWarnActingUpdates.js

    add @flow annotation
    Sunil Pai committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    b0391d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. rename ReactShouldWarnActingUpdates to ReactActingRendererSigi, merge…

    … act/dom fixture folders
    Sunil Pai committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    29e2cc7 View commit details
    Browse the repository at this point in the history
  2. augh prettier

    Sunil Pai committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    cd695e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Configuration menu
    Copy the full SHA
    d00d827 View commit details
    Browse the repository at this point in the history
  2. s/console.error/spy

    Sunil Pai committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    82124cc View commit details
    Browse the repository at this point in the history
  3. run yarn before dom-fixture tests

    Sunil Pai committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    c2a52f5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Configuration menu
    Copy the full SHA
    381d292 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    275d47c View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Configuration menu
    Copy the full SHA
    26ce8b4 View commit details
    Browse the repository at this point in the history