-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using the wrong renderer's act() should warn #15399
using the wrong renderer's act() should warn #15399
Commits on Apr 3, 2019
-
mark react-events as private so we publish script skips it for now
Sunil Pai committedApr 3, 2019 Configuration menu - View commit details
-
Copy full SHA for c35e37a - Browse repository at this point
Copy the full SHA c35e37aView commit details -
Merge remote-tracking branch 'upstream/master'
Sunil Pai committedApr 3, 2019 Configuration menu - View commit details
-
Copy full SHA for dc605c1 - Browse repository at this point
Copy the full SHA dc605c1View commit details -
Merge remote-tracking branch 'upstream/master'
Sunil Pai committedApr 3, 2019 Configuration menu - View commit details
-
Copy full SHA for a09bd0f - Browse repository at this point
Copy the full SHA a09bd0fView commit details
Commits on Apr 12, 2019
-
Merge remote-tracking branch 'upstream/master'
Sunil Pai committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for 48ffcee - Browse repository at this point
Copy the full SHA 48ffceeView commit details -
warn when using the wrong act() around create/updates
via facebook#15319 This solves 2 specific problems - - using the 'wrong' act() doesn't silence the warning - using the wrong act logs a warning It does this by using an empty object on the reconciler as the identity of ReactShouldWarnActingUpdates.current. We also add this check when calling createContainer() to catch the common failure of this happening right in the beginning.
Sunil Pai committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for f0c3493 - Browse repository at this point
Copy the full SHA f0c3493View commit details -
Merge remote-tracking branch 'upstream/master' into renderer-specific…
…-act-warning
Sunil Pai committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for c1e2986 - Browse repository at this point
Copy the full SHA c1e2986View commit details
Commits on Apr 14, 2019
-
make a proper fixture for act()
made fixtures/act for act(). specifically, this lets us tests how act behaves when you use the wrong act() for the wrong renderer. also mvoes dom/../act-dom.html to this fixture.
Sunil Pai committedApr 14, 2019 Configuration menu - View commit details
-
Copy full SHA for bd31fed - Browse repository at this point
Copy the full SHA bd31fedView commit details -
cleanup fixtures/dom/.gitignore
Sunil Pai committedApr 14, 2019 Configuration menu - View commit details
-
Copy full SHA for b417644 - Browse repository at this point
Copy the full SHA b417644View commit details -
verify that it 'works' with art+dom
Sunil Pai committedApr 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 6812f6e - Browse repository at this point
Copy the full SHA 6812f6eView commit details -
verify that it 'works' with art+test
Sunil Pai committedApr 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 190f656 - Browse repository at this point
Copy the full SHA 190f656View commit details -
Sunil Pai committed
Apr 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 7caa1b2 - Browse repository at this point
Copy the full SHA 7caa1b2View commit details
Commits on Apr 15, 2019
-
Sunil Pai committed
Apr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 4fc4c39 - Browse repository at this point
Copy the full SHA 4fc4c39View commit details -
Stop tracking bundle sizes (facebook#15404)
* [sizebot] Fail gracefully if CI returns invalid response Moves the `response.json()` call into the catch block. * Stop tracking bundle sizes
Configuration menu - View commit details
-
Copy full SHA for 91c5d79 - Browse repository at this point
Copy the full SHA 91c5d79View commit details -
React events: ignore device buttons that aren't for primary interacti…
…ons (facebook#15402) The Pointer Events spec mentions that the value of `button` in a nativeEvent can be anything between 0 and 5 for "down" events. We only care about those with a value of 0.
Configuration menu - View commit details
-
Copy full SHA for 46a4237 - Browse repository at this point
Copy the full SHA 46a4237View commit details -
warn when using the wrong act() around create/updates
via facebook#15319 This solves 2 specific problems - - using the 'wrong' act() doesn't silence the warning - using the wrong act logs a warning It does this by using an empty object on the reconciler as the identity of ReactShouldWarnActingUpdates.current. We also add this check when calling createContainer() to catch the common failure of this happening right in the beginning. make a proper fixture for act() made fixtures/act for act(). specifically, this lets us tests how act behaves when you use the wrong act() for the wrong renderer. also mvoes dom/../act-dom.html to this fixture. cleanup fixtures/dom/.gitignore verify that it 'works' with art+dom verify that it 'works' with art+test augh prettier tweak warning messages
Sunil Pai committedApr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for e4d93a7 - Browse repository at this point
Copy the full SHA e4d93a7View commit details -
Merge branch 'renderer-specific-act-warning' of github.com:threepoint…
…one/react into renderer-specific-act-warning
Sunil Pai committedApr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for da0e642 - Browse repository at this point
Copy the full SHA da0e642View commit details -
Merge remote-tracking branch 'upstream/master' into renderer-specific…
…-act-warning
Sunil Pai committedApr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for d008007 - Browse repository at this point
Copy the full SHA d008007View commit details -
lose ReactActingUpdatesSigil.js, use flushPassiveEffects as the actin…
…g sigil
Sunil Pai committedApr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 0aebde1 - Browse repository at this point
Copy the full SHA 0aebde1View commit details -
Sunil Pai committed
Apr 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 7f3fd8f - Browse repository at this point
Copy the full SHA 7f3fd8fView commit details
Commits on Apr 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b0391d7 - Browse repository at this point
Copy the full SHA b0391d7View commit details
Commits on Apr 18, 2019
-
rename ReactShouldWarnActingUpdates to ReactActingRendererSigi, merge…
… act/dom fixture folders
Sunil Pai committedApr 18, 2019 Configuration menu - View commit details
-
Copy full SHA for 29e2cc7 - Browse repository at this point
Copy the full SHA 29e2cc7View commit details -
Sunil Pai committed
Apr 18, 2019 Configuration menu - View commit details
-
Copy full SHA for cd695e6 - Browse repository at this point
Copy the full SHA cd695e6View commit details
Commits on Apr 23, 2019
-
move the check to updatecontainer, run the act fixtures in ci
Sunil Pai committedApr 23, 2019 Configuration menu - View commit details
-
Copy full SHA for d00d827 - Browse repository at this point
Copy the full SHA d00d827View commit details -
Sunil Pai committed
Apr 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 82124cc - Browse repository at this point
Copy the full SHA 82124ccView commit details -
run yarn before dom-fixture tests
Sunil Pai committedApr 23, 2019 Configuration menu - View commit details
-
Copy full SHA for c2a52f5 - Browse repository at this point
Copy the full SHA c2a52f5View commit details
Commits on May 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 381d292 - Browse repository at this point
Copy the full SHA 381d292View commit details -
Configuration menu - View commit details
-
Copy full SHA for 275d47c - Browse repository at this point
Copy the full SHA 275d47cView commit details
Commits on May 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 26ce8b4 - Browse repository at this point
Copy the full SHA 26ce8b4View commit details