Cleanup lint warnings #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commited as cb01363 (not worth the branching history) |
bvaughn
added a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Use @reach MenuButton for owner stack menu [WIP]
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Summary --- Syncs the state of all 3 horizontal pan and zoom views. Fixes the known issue from the first PR in this stack. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code * `yarn test`: no new tests; all existing ones passing * `yarn start`: manual test: panning and zooming on any horizontal pan and zoom view also pans and zooms the others.
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 19, 2020
Summary --- Syncs the state of all 3 horizontal pan and zoom views. Fixes the known issue from the first PR in this stack. Test Plan --- * `yarn lint` * `yarn flow`: no errors in changed code * `yarn test`: no new tests; all existing ones passing * `yarn start`: manual test: panning and zooming on any horizontal pan and zoom view also pans and zooms the others.
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grunt lintis passing completely for the first time