Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat Bundle Followup Umbrella #9321

Closed
19 of 23 tasks
gaearon opened this issue Apr 3, 2017 · 4 comments
Closed
19 of 23 tasks

Flat Bundle Followup Umbrella #9321

gaearon opened this issue Apr 3, 2017 · 4 comments
Assignees

Comments

@gaearon
Copy link
Collaborator

gaearon commented Apr 3, 2017

Now that flat bundles are mostly done (#9327), separating out followup work into a separate issue.

  • Should ReactDebugCurrentFrame be in isomorphic package? Make ReactDebugCurrentFrame shared state between core and renderers #9365
  • Does --extractErrors fully work? It does update the file, but I'm still seeing "out of sync" console spam on rebuilds.
  • What happens if user forgets to envify process.env.NODE_ENV with webpack or use dead code elimination? Would it bundle both bundles? Sounds like even worse than what happens now. Would the user see any warnings?
  • Wrap CommonJS bundles into conditions React 16.0.0-alpha 7 does not bundle correctly in a project using rollup #9361
  • Add a way to see bundle size change
  • Address internal FB invariant issue (I think they wanted it to be ignored so it's used verbatim)
  • Figure out RN rollout strategy
    • When does it go 100% Fiber? Do we switch to flat bundles after that?
    • See gaearon@db1f704 for possible workaround for circular injection
    • Flat ReactNative bundle would require flat React bundle but that's not what's shipped on npm
  • Make sure error codes transform still works
  • Add a fixture for ReactART
  • Make a final decision on how we bundle server renderer
  • Remove providesModule in source
  • Maybe reduce duplication between UMD bundles (e.g. put object-assign on React internals) Share Object.assign polyfill between UMD builds #10671
  • Convert source to ES6 modules
  • Update release documentation
  • Extract shared state to npm package
  • Use named imports in more places (eg event system)
  • Figure out a static injection mechanism for www and RN
  • Investigate mangling and GCC optimizations
  • Figure out how to share build process with third party renderers (e.g. ART for starters)
  • Simplify the default build process to not run FB bundle builds, come up with a better strategy for FB only builds maybe?
@quantizor
Copy link
Contributor

The bundle size analysis could be done in a Dangerfile. Jest uses the build job for a variety of arbitrary tasks like scanning for "use strict", for example.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 30, 2017

I think we've done everything planned here. GCC advanced is still not there but we have a separate issue tracking it. No plans to share build process with other renderers for now.

@gaearon gaearon closed this as completed Nov 30, 2017
@blling
Copy link

blling commented Nov 30, 2017

What is GCC?

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 30, 2017

Google Closure Compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants