Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark and Clean Up _mountImage Strings #851

Closed
sebmarkbage opened this issue Jan 9, 2014 · 1 comment · Fixed by #852
Closed

Benchmark and Clean Up _mountImage Strings #851

sebmarkbage opened this issue Jan 9, 2014 · 1 comment · Fixed by #852

Comments

@sebmarkbage
Copy link
Collaborator

We're currently not cleaning up strings from _mountImage after a component gets mounted. That memory could be freed. But the act of freeing the memory could be more expensive than it's worth. Needs proper benchmarks and a workaround.

@sophiebits
Copy link
Collaborator

I noticed this a little while ago. I'm not sure why we need to store it on the child instance in the first place -- PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants