Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the view difference in the reuse markup error configurable. #7939

Closed
PepijnSenders opened this issue Oct 11, 2016 · 1 comment
Closed

Comments

@PepijnSenders
Copy link

PepijnSenders commented Oct 11, 2016

Do you want to request a feature or report a bug?

I'm requesting a feature.

What is the current behavior?

Currently the way the reuse markup error is displayed the difference is hardcoded to 20 characters of code on each side. This should be a configurable property.

The code can be found here: https://github.com/facebook/react/blob/master/src/renderers/dom/client/ReactMount.js#L677

20 characters is sometimes a bit hard to debug, especially with css-in-js libraries where your div's usually also contain an obfuscated class name. Being able to make this a larger number could help with debugging where it went wrong.

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

We don't show that particular warning anymore. For thoughts on future similar warning please post in #10085.

@gaearon gaearon closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants