Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form submit button has empty values in 15.2.0 #7179

Closed
h8rry opened this issue Jul 3, 2016 · 3 comments
Closed

Form submit button has empty values in 15.2.0 #7179

h8rry opened this issue Jul 3, 2016 · 3 comments

Comments

@h8rry
Copy link

h8rry commented Jul 3, 2016

Do you want to request a feature or report a bug?

This is a bug

What is the current behavior?

screen shot 2016-07-03 at 4 12 19 pm
screen shot 2016-07-03 at 4 11 15 pm

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/reactjs/69z2wepo/).

Using 15.2.0 react and react-dom

What is the expected behavior?

screen shot 2016-07-03 at 4 13 05 pm
screen shot 2016-07-03 at 4 13 10 pm

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

In 15.2.0, extra attributes name and value with empty values are added to the submit button of a form.

It works in 15.1.0.

@kostasmanionis
Copy link

Uhhh, seems that this was missed on #6406? The culprit here is postMountWrapper in ReactDOMInput.js

node.value = node.value; 🙊

@franzejr
Copy link

franzejr commented Jul 3, 2016

@h8rry, I think your links for behavior are not saved correctly.

Current behavior(ReactJS 15.2.0):
https://jsfiddle.net/69z2wepo/47613/

ReactJS (15.1.0):
https://jsfiddle.net/69z2wepo/47612/

@zpao
Copy link
Member

zpao commented Jul 5, 2016

Thanks for catching! I put up something that at least fixes the constant render case. I think we'd always have this problem if you toggled value of these inputs from a real value to undefined so I'm not too worried about trying to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants