-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing spacebar on a checked radio button only fires click in some browsers #4854
Comments
I've verified that this is still an issue with the latest React 16 RC: https://jsfiddle.net/snshd0av/ |
I was able to reproduce this too here in vanilla javascript, and was able to throw in a quick fix in there too. I wonder if a similar fix can be transferred to React's codebase. I'd be thrilled to attempt to do so with some guidance if possible (hoping the "mentorship" tag has to do with that 🙏). |
Test Cases
Repeating Click events
Only 1 event
Potentially related? Bug's submitted Spec issue raised Rather than introducing a patch it might be worth us closing this ticket and letting the WHATWG decide what the right approach to take is, it may be inconsistent between vendors but the issue is not affecting React users dis-proportionally here |
I agree. I say we wait to see what WHATWG decides. It also avoids possible regressions with the change event plugin, which have been historically difficult to regression test. |
Closing this out, but happy to pick up the discussion once WHATWG makes a decision. |
http://jsbin.com/yiyusuwuco/1/edit?js,console,output
This is entirely the browsers' fault, but, since React's Synthetic Event system is trying to fully normalize inconsistencies like this, here's an obscure one for the list :/
I, at least, prefer Firefox's behavior: I expect real clicks and synthetic (keyboard-originated) clicks to have the same conditions for firing.
(Incidentally, this feels to me like it might've been an accident in Chrome rather than an explicit decision. Is there some place to file this bug with them? I feel like that's pretty pie-in-the-sky, though ;P)
The text was updated successfully, but these errors were encountered: