Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Named hooks error badge #21817

Closed
bvaughn opened this issue Jul 7, 2021 · 0 comments · Fixed by #21820
Closed

[DevTools] Named hooks error badge #21817

bvaughn opened this issue Jul 7, 2021 · 0 comments · Fixed by #21820

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jul 7, 2021

The named hooks cache returns Array<string | null> | null The first (mixed array of string and null) indicates an overall success, even if some names couldn't be inferred. The second indicates an error (e.g. couldn't locate or load source map).

In the event of the 2nd response type, the UI currently does nothing (falls back to default) but we should show an error badge (maybe a disabled but red icon with a tooltip saying there was an error) since it's a confusing user experience to just do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant