-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTools] Use line number and column number to match hook #21792
Comments
While we're on the subject: Column numbers in particular are where a lot of inconsistencies between tools/engines' representations occur and off-by-one errors creep in.
So I suspect we have an incorrect conversion here already - we should fix it and signpost assumptions/conversions more clearly. |
Reopening to address this follow up comment from @motiz88:
|
DevTools named hook parsing logic currently matches AST nodes using the original line number:
react/packages/react-devtools-extensions/src/parseHookNames.js
Lines 341 to 346 in ed6c091
But this may not be sufficient, as mentioned in comment #21641 (comment):
The text was updated successfully, but these errors were encountered: