Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: react-devtools doesn't install on macs with the M1 chip because it has an incompatible version of electron #21210

Closed
coreyar opened this issue Apr 8, 2021 · 4 comments

Comments

@coreyar
Copy link

coreyar commented Apr 8, 2021

React version: 16.13.1
react-devtools 4.10.0

Steps To Reproduce

  1. Install react-devtools 4.10.0 on a mac with an M1 chip
  2. The installation will fail becauase electron 9.4.4 is incompatible

Link to code example:
This commit has a version bump for electron but it looks like the package was never republished because the react-devtools package version wasn't updated
beb38ab#diff-643298d1c50c9333dd9f9b34d4554595c61a68758147effab85d58330772e8a1

The current behavior

error /~/node_modules/react-devtools/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /~/node_modules/react-devtools/node_modules/electron
Output:
HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v9.4.4/electron-v9.4.4-darwin-arm64.zip
    at EventEmitter.<anonymous> (/~/node_modules/got/source/as-stream.js:35:24)
    at EventEmitter.emit (node:events:369:20)
    at module.exports (/~e/node_modules/got/source/get-response.js:22:10)
    at ClientRequest.handleResponse (/~/node_modules/got/source/request-as-event-emitter.js:155:5)
    at Object.onceWrapper (node:events:476:26)
    at ClientRequest.emit (node:events:381:22)
    at ClientRequest.origin.emit (/~node_modules/@szmarczak/http-timer/source/index.js:37:11)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:646:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:129:17)
    at TLSSocket.socketOnData (node:_http_client:512:22)

The expected behavior

Installs without errors

@coreyar coreyar added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Apr 8, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Apr 8, 2021

This was already reported in #20454 and fixed via #20496. It just hasn't been published to NPM yet.

@bvaughn bvaughn added Component: Developer Tools Resolution: Duplicate and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Apr 8, 2021
@coreyar
Copy link
Author

coreyar commented Apr 9, 2021

ok thanks any timeline on publishing it?

@coreyar coreyar closed this as completed Apr 9, 2021
@coreyar coreyar reopened this Apr 9, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Apr 9, 2021

I'm going to try to do it this morning. :)

@bvaughn
Copy link
Contributor

bvaughn commented Apr 9, 2021

published as 4.11.0

@bvaughn bvaughn closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants