Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content property #119

Closed
zpao opened this issue Jun 21, 2013 · 0 comments · Fixed by #120
Closed

Remove content property #119

zpao opened this issue Jun 21, 2013 · 0 comments · Fixed by #120
Milestone

Comments

@zpao
Copy link
Member

zpao commented Jun 21, 2013

We currently have 2 paths for having child content in ReactNativeComponents: this.props.children and this.props.content. Supporting both of these paths makes our code more complicated than it needs to be, and really a single child is the same as content.

We were using this for <option> to make sure it only had a single text child, thought it doesn't look like we are anymore...

@zpao zpao closed this as completed in e998041 Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant