Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate need to feature check cancel and close events. #11598

Closed
1 of 3 tasks
nhunzaker opened this issue Nov 20, 2017 · 3 comments
Closed
1 of 3 tasks

Investigate need to feature check cancel and close events. #11598

nhunzaker opened this issue Nov 20, 2017 · 3 comments
Assignees
Labels
Component: DOM Resolution: Stale Automatically closed due to inactivity Type: Enhancement

Comments

@nhunzaker
Copy link
Contributor

nhunzaker commented Nov 20, 2017

The ReactBrowserEventEmitter checks for browser support of the cancel and close events. before attaching those listeners.

I'm curious why this is necessary. Did we need it for IE8?

I'd like to:

  • Determine if there are ramifications to removing these checks
  • Add comments above those lines if these checks are necessary.
  • Maybe eliminate isEventSupported.js this is needed to check for input in ChangeEventPlugin
@nhunzaker nhunzaker self-assigned this Nov 20, 2017
@nhunzaker
Copy link
Contributor Author

Assigning this to me as a part of #11550, but I'd greatly appreciate any insight.

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DOM Resolution: Stale Automatically closed due to inactivity Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants