-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected SSR difference warning with SVG <filter> primitives #10772
Comments
Looks like the ol' SVG cares about casing but HTML doesn't is back at it again! |
Can you please provide a minimal reproducing example? |
@nhunzaker I've seen this issue recently but ignored it thinking it was my fault (react 16.0.0). In any case, if I remember correctly I had an |
No, this sounds right. React asks you to always use the React canonical naming (camelCase) even if the lowercase version "appears" to work. |
Actually wait, I'm wrong. It doesn't sound right based on your description. Could be a bug. |
I filed a new issue for the I don't think it's related to this issue. |
I'll work on it today and share it in the ticket you created. |
Quick fix: canHydrateInstance(
instance: Instance | TextInstance,
type: string,
props: Props,
): boolean {
return (
instance.nodeType === ELEMENT_NODE &&
type.toLowerCase() === instance.nodeName.toLowerCase()
);
}, |
Or maybe we should check the namespace, and apply case-insensitive check only to HTML. |
React |
In my case |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I've started recieving this warning about my SVGs which is using feGaussianBlur:
Warning: Expected server HTML to contain a matching <feGaussianBlur> in <filter>.
What is the expected behavior?
Should be no warnings because there are no difference.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Such behavior started right after updating to
React 16.0.0-rc.3
and never happened withReact 15.6.1
The text was updated successfully, but these errors were encountered: