Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-art to use new prop-types package #10625

Closed
flarnie opened this issue Sep 6, 2017 · 3 comments
Closed

Update react-art to use new prop-types package #10625

flarnie opened this issue Sep 6, 2017 · 3 comments
Assignees
Milestone

Comments

@flarnie
Copy link
Contributor

flarnie commented Sep 6, 2017

Do you want to request a feature or report a bug?
Will stop react-art from throwing warnings when used with recent React. I haven't tested this manually, but it seems like it will throw because it's using the old style of getting PropTypes from React directly.

https://github.com/reactjs/react-art/blob/master/src/Wedge.art.js#L28

Also the package is not listing prop-types as a dependency -
https://github.com/reactjs/react-art/blob/master/package.json
and
https://github.com/facebook/react/blob/master/packages/react-art/package.json

What is the current behavior?
It probably throws a warning, or at least models out-of-date syntax which won't work once we deprecate React.PropTypes.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/ebsrpraL/).

TODO

What is the expected behavior?

Uses prop-types package, as shown in the docs.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React 16.0 beta/RC

@flarnie flarnie added this to the 16.0 milestone Sep 6, 2017
@flarnie flarnie self-assigned this Sep 6, 2017
@gaearon
Copy link
Collaborator

gaearon commented Sep 6, 2017

Isn't this only relevant for old code in react-art repo? My understanding is that code is not used anywhere. Currently React repo is the source of truth, and we shouldn't have that problem in it.

@gaearon
Copy link
Collaborator

gaearon commented Sep 6, 2017

(Longer term we should move source of truth back into react-art but we can't until we expose the reconciler. There is an issue about this.)

@sophiebits
Copy link
Contributor

Fixed by #10629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants