Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Infinite loop when error is thrown in render() #10137

Closed
steadicat opened this issue Jul 11, 2017 · 1 comment
Closed

[Fiber] Infinite loop when error is thrown in render() #10137

steadicat opened this issue Jul 11, 2017 · 1 comment

Comments

@steadicat
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Using React 0.16 alpha 13 (and most other recent versions of 0.16, IIRC), whenever an error is thrown inside of render(), React (Fiber) goes into an infinite loop. Screenshot:
screen shot 2017-07-10 at 5 04 30 pm

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).
Unfortunately I don’t have a minimal repro case yet. I just wanted to flag this before 0.16 goes into beta. I don't think there's anything we're doing that's special (no weird recursive componentDidUpdate calls or similar). I tried stepping within the loop and it's all inside the Fiber internals, no user code involved.

What is the expected behavior?
React throws an error and stops.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Repros with 0.16, works fine with React 0.15.

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2017

Thanks for reporting! It's a known issue in the open source alphas of ReactDOM. We're tracking it in #9193 and will fix soon.

@gaearon gaearon closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants