From edc9c2fc70b0c8141a91244d7e14152d28f4479b Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Thu, 31 Aug 2017 16:46:44 -0700 Subject: [PATCH] [attribute-behavior] Canonicalize values immediately after reading them (#10584) In case they are mutated --- fixtures/attribute-behavior/src/App.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js index b7a8037b0c0cf..156efa418f2c4 100644 --- a/fixtures/attribute-behavior/src/App.js +++ b/fixtures/attribute-behavior/src/App.js @@ -2573,6 +2573,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) { }; let defaultValue; + let canonicalDefaultValue; let result; let canonicalResult; let ssrResult; @@ -2586,6 +2587,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) { try { renderer.render(React.createElement(tagName, baseProps), container); defaultValue = read(container.firstChild); + canonicalDefaultValue = getCanonicalizedValue(defaultValue); renderer.render(React.createElement(tagName, props), container); result = read(container.firstChild); canonicalResult = getCanonicalizedValue(result); @@ -2662,7 +2664,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) { defaultValue, result, canonicalResult, - canonicalDefaultValue: getCanonicalizedValue(defaultValue), + canonicalDefaultValue, didWarn, didError, ssrResult,