Skip to content

Commit d3a81b3

Browse files
committed
Try this
1 parent 1c121d0 commit d3a81b3

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

packages/react-dom/src/__tests__/ReactBrowserEventEmitter-test.js

+14-4
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ let PARENT;
3535
let CHILD;
3636
let BUTTON;
3737

38+
let renderTree;
3839
let putListener;
3940
let deleteAllListeners;
4041

@@ -71,7 +72,7 @@ describe('ReactBrowserEventEmitter', () => {
7172

7273
const root = ReactDOMClient.createRoot(container);
7374

74-
async function renderTree() {
75+
renderTree = async function () {
7576
await act(() => {
7677
root.render(
7778
<div ref={c => (GRANDPARENT = c)} {...GRANDPARENT_PROPS}>
@@ -86,7 +87,7 @@ describe('ReactBrowserEventEmitter', () => {
8687
</div>,
8788
);
8889
});
89-
}
90+
};
9091

9192
putListener = async function (node, eventName, listener) {
9293
switch (node) {
@@ -126,8 +127,6 @@ describe('ReactBrowserEventEmitter', () => {
126127
};
127128

128129
idCallOrder = [];
129-
130-
return renderTree();
131130
});
132131

133132
afterEach(() => {
@@ -136,6 +135,7 @@ describe('ReactBrowserEventEmitter', () => {
136135
});
137136

138137
it('should bubble simply', async () => {
138+
await renderTree();
139139
await putListener(CHILD, ON_CLICK_KEY, recordID.bind(null, CHILD));
140140
await putListener(PARENT, ON_CLICK_KEY, recordID.bind(null, PARENT));
141141
await putListener(
@@ -153,6 +153,7 @@ describe('ReactBrowserEventEmitter', () => {
153153
});
154154

155155
it('should bubble to the right handler after an update', async () => {
156+
await renderTree();
156157
await putListener(
157158
GRANDPARENT,
158159
ON_CLICK_KEY,
@@ -181,6 +182,7 @@ describe('ReactBrowserEventEmitter', () => {
181182
});
182183

183184
it('should continue bubbling if an error is thrown', async () => {
185+
await renderTree();
184186
await putListener(CHILD, ON_CLICK_KEY, recordID.bind(null, CHILD));
185187
await putListener(PARENT, ON_CLICK_KEY, function () {
186188
recordID(PARENT);
@@ -203,6 +205,7 @@ describe('ReactBrowserEventEmitter', () => {
203205
});
204206

205207
it('should set currentTarget', async () => {
208+
await renderTree();
206209
await putListener(CHILD, ON_CLICK_KEY, function (event) {
207210
recordID(CHILD);
208211
expect(event.currentTarget).toBe(CHILD);
@@ -225,6 +228,7 @@ describe('ReactBrowserEventEmitter', () => {
225228
});
226229

227230
it('should support stopPropagation()', async () => {
231+
await renderTree();
228232
await putListener(CHILD, ON_CLICK_KEY, recordID.bind(null, CHILD));
229233
await putListener(
230234
PARENT,
@@ -245,6 +249,7 @@ describe('ReactBrowserEventEmitter', () => {
245249
});
246250

247251
it('should support overriding .isPropagationStopped()', async () => {
252+
await renderTree();
248253
// Ew. See D4504876.
249254
await putListener(CHILD, ON_CLICK_KEY, recordID.bind(null, CHILD));
250255
await putListener(PARENT, ON_CLICK_KEY, function (e) {
@@ -266,6 +271,7 @@ describe('ReactBrowserEventEmitter', () => {
266271
});
267272

268273
it('should stop after first dispatch if stopPropagation', async () => {
274+
await renderTree();
269275
await putListener(
270276
CHILD,
271277
ON_CLICK_KEY,
@@ -285,6 +291,7 @@ describe('ReactBrowserEventEmitter', () => {
285291
});
286292

287293
it('should not stopPropagation if false is returned', async () => {
294+
await renderTree();
288295
await putListener(
289296
CHILD,
290297
ON_CLICK_KEY,
@@ -315,6 +322,7 @@ describe('ReactBrowserEventEmitter', () => {
315322
*/
316323

317324
it('should invoke handlers that were removed while bubbling', async () => {
325+
await renderTree();
318326
const handleParentClick = jest.fn();
319327
const handleChildClick = async function (event) {
320328
await deleteAllListeners(PARENT);
@@ -328,6 +336,7 @@ describe('ReactBrowserEventEmitter', () => {
328336
});
329337

330338
it('should not invoke newly inserted handlers while bubbling', async () => {
339+
await renderTree();
331340
const handleParentClick = jest.fn();
332341
const handleChildClick = async function (event) {
333342
await putListener(PARENT, ON_CLICK_KEY, handleParentClick);
@@ -340,6 +349,7 @@ describe('ReactBrowserEventEmitter', () => {
340349
});
341350

342351
it('should have mouse enter simulated by test utils', async () => {
352+
await renderTree();
343353
await putListener(CHILD, ON_MOUSE_ENTER_KEY, recordID.bind(null, CHILD));
344354
await act(() => {
345355
ReactTestUtils.Simulate.mouseEnter(CHILD);

0 commit comments

Comments
 (0)