From cbc484b5ae8cb683aef5ee61fac468679e9bb2aa Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Thu, 25 Nov 2021 01:37:09 +0000 Subject: [PATCH] Update attribute-behavior fixture (#22522) * Fix missing key warning * Add build instructions * Update interpretation now that React 17 is latest stable and 18 is next * Ignore ReactDOM.render deprecation warning * Ensure a server implementation with `renderToString` is used * Update AttributeTableSnapshot * Ensure Popover doesn't overflow --- fixtures/attribute-behavior/.gitignore | 2 +- .../AttributeTableSnapshot.md | 490 ++++++++++-------- fixtures/attribute-behavior/README.md | 7 +- fixtures/attribute-behavior/package.json | 2 +- fixtures/attribute-behavior/src/App.js | 11 +- 5 files changed, 282 insertions(+), 230 deletions(-) diff --git a/fixtures/attribute-behavior/.gitignore b/fixtures/attribute-behavior/.gitignore index 49c5a75db9401..9190def2d174c 100644 --- a/fixtures/attribute-behavior/.gitignore +++ b/fixtures/attribute-behavior/.gitignore @@ -10,7 +10,7 @@ /build /public/react.development.js /public/react-dom.development.js -/public/react-dom-server.browser.development.js +/public/react-dom-server-legacy.browser.development.js # misc .DS_Store diff --git a/fixtures/attribute-behavior/AttributeTableSnapshot.md b/fixtures/attribute-behavior/AttributeTableSnapshot.md index 5a57877f1b643..61037b69c4070 100644 --- a/fixtures/attribute-behavior/AttributeTableSnapshot.md +++ b/fixtures/attribute-behavior/AttributeTableSnapshot.md @@ -526,23 +526,23 @@ ## `amplitude` (on `` inside ``) | Test Case | Flags | Result | | --- | --- | --- | -| `amplitude=(string)`| (changed)| `` | +| `amplitude=(string)`| (initial)| `` | | `amplitude=(empty string)`| (changed)| `` | -| `amplitude=(array with string)`| (changed)| `` | +| `amplitude=(array with string)`| (initial)| `` | | `amplitude=(empty array)`| (changed)| `` | -| `amplitude=(object)`| (changed)| `` | +| `amplitude=(object)`| (initial)| `` | | `amplitude=(numeric string)`| (changed)| `` | | `amplitude=(-1)`| (changed)| `` | | `amplitude=(0)`| (changed)| `` | | `amplitude=(integer)`| (initial)| `` | -| `amplitude=(NaN)`| (changed, warning)| `` | +| `amplitude=(NaN)`| (initial, warning)| `` | | `amplitude=(float)`| (changed)| `` | | `amplitude=(true)`| (initial, warning)| `` | | `amplitude=(false)`| (initial, warning)| `` | -| `amplitude=(string 'true')`| (changed)| `` | -| `amplitude=(string 'false')`| (changed)| `` | -| `amplitude=(string 'on')`| (changed)| `` | -| `amplitude=(string 'off')`| (changed)| `` | +| `amplitude=(string 'true')`| (initial)| `` | +| `amplitude=(string 'false')`| (initial)| `` | +| `amplitude=(string 'on')`| (initial)| `` | +| `amplitude=(string 'off')`| (initial)| `` | | `amplitude=(symbol)`| (initial, warning)| `` | | `amplitude=(function)`| (initial, warning)| `` | | `amplitude=(null)`| (initial)| `` | @@ -830,17 +830,17 @@ | `autoComplete=(empty string)`| (initial)| `` | | `autoComplete=(array with string)`| (changed)| `"email"` | | `autoComplete=(empty array)`| (initial)| `` | -| `autoComplete=(object)`| (changed)| `"result of toString()"` | -| `autoComplete=(numeric string)`| (changed)| `"42"` | -| `autoComplete=(-1)`| (changed)| `"-1"` | -| `autoComplete=(0)`| (changed)| `"0"` | -| `autoComplete=(integer)`| (changed)| `"1"` | -| `autoComplete=(NaN)`| (changed, warning)| `"NaN"` | -| `autoComplete=(float)`| (changed)| `"99.99"` | +| `autoComplete=(object)`| (initial)| `` | +| `autoComplete=(numeric string)`| (initial)| `` | +| `autoComplete=(-1)`| (initial)| `` | +| `autoComplete=(0)`| (initial)| `` | +| `autoComplete=(integer)`| (initial)| `` | +| `autoComplete=(NaN)`| (initial, warning)| `` | +| `autoComplete=(float)`| (initial)| `` | | `autoComplete=(true)`| (initial, warning)| `` | | `autoComplete=(false)`| (initial, warning)| `` | -| `autoComplete=(string 'true')`| (changed)| `"true"` | -| `autoComplete=(string 'false')`| (changed)| `"false"` | +| `autoComplete=(string 'true')`| (initial)| `` | +| `autoComplete=(string 'false')`| (initial)| `` | | `autoComplete=(string 'on')`| (changed)| `"on"` | | `autoComplete=(string 'off')`| (changed)| `"off"` | | `autoComplete=(symbol)`| (initial, warning)| `` | @@ -1469,16 +1469,16 @@ | `children=(string 'on')`| (initial)| `[]` | | `children=(string 'off')`| (initial)| `[]` | | `children=(symbol)`| (initial)| `[]` | -| `children=(function)`| (initial, warning, ssr warning)| `[]` | +| `children=(function)`| (initial, warning)| `[]` | | `children=(null)`| (initial)| `[]` | | `children=(undefined)`| (initial)| `[]` | ## `cite` (on `
` inside `
`) | Test Case | Flags | Result | | --- | --- | --- | -| `cite=(string)`| (changed)| `"http://reactjs.com/"` | +| `cite=(string)`| (changed)| `"https://reactjs.com/"` | | `cite=(empty string)`| (changed)| `"http://localhost:3000/"` | -| `cite=(array with string)`| (changed)| `"http://reactjs.com/"` | +| `cite=(array with string)`| (changed)| `"https://reactjs.com/"` | | `cite=(empty array)`| (changed)| `"http://localhost:3000/"` | | `cite=(object)`| (changed)| `"http://localhost:3000/result%20of%20toString()"` | | `cite=(numeric string)`| (changed)| `"http://localhost:3000/42"` | @@ -2560,7 +2560,7 @@ | `defaultChecked=(-1)`| (changed)| `` | | `defaultChecked=(0)`| (initial)| `` | | `defaultChecked=(integer)`| (changed)| `` | -| `defaultChecked=(NaN)`| (initial, warning, ssr warning)| `` | +| `defaultChecked=(NaN)`| (initial, warning)| `` | | `defaultChecked=(float)`| (changed)| `` | | `defaultChecked=(true)`| (changed)| `` | | `defaultChecked=(false)`| (initial)| `` | @@ -2593,9 +2593,9 @@ | `defaultValue=(string 'false')`| (changed)| `"false"` | | `defaultValue=(string 'on')`| (changed)| `"on"` | | `defaultValue=(string 'off')`| (changed)| `"off"` | -| `defaultValue=(symbol)`| (initial, ssr warning)| `` | -| `defaultValue=(function)`| (initial, ssr warning)| `` | -| `defaultValue=(null)`| (initial, ssr warning)| `` | +| `defaultValue=(symbol)`| (initial)| `` | +| `defaultValue=(function)`| (initial)| `` | +| `defaultValue=(null)`| (initial)| `` | | `defaultValue=(undefined)`| (initial)| `` | ## `defaultValuE` (on `` inside `
`) @@ -2676,23 +2676,23 @@ ## `diffuseConstant` (on `` inside ``) | Test Case | Flags | Result | | --- | --- | --- | -| `diffuseConstant=(string)`| (changed)| `` | +| `diffuseConstant=(string)`| (initial)| `` | | `diffuseConstant=(empty string)`| (changed)| `` | -| `diffuseConstant=(array with string)`| (changed)| `` | +| `diffuseConstant=(array with string)`| (initial)| `` | | `diffuseConstant=(empty array)`| (changed)| `` | -| `diffuseConstant=(object)`| (changed)| `` | +| `diffuseConstant=(object)`| (initial)| `` | | `diffuseConstant=(numeric string)`| (changed)| `` | | `diffuseConstant=(-1)`| (changed)| `` | | `diffuseConstant=(0)`| (changed)| `` | | `diffuseConstant=(integer)`| (initial)| `` | -| `diffuseConstant=(NaN)`| (changed, warning)| `` | +| `diffuseConstant=(NaN)`| (initial, warning)| `` | | `diffuseConstant=(float)`| (changed)| `` | | `diffuseConstant=(true)`| (initial, warning)| `` | | `diffuseConstant=(false)`| (initial, warning)| `` | -| `diffuseConstant=(string 'true')`| (changed)| `` | -| `diffuseConstant=(string 'false')`| (changed)| `` | -| `diffuseConstant=(string 'on')`| (changed)| `` | -| `diffuseConstant=(string 'off')`| (changed)| `` | +| `diffuseConstant=(string 'true')`| (initial)| `` | +| `diffuseConstant=(string 'false')`| (initial)| `` | +| `diffuseConstant=(string 'on')`| (initial)| `` | +| `diffuseConstant=(string 'off')`| (initial)| `` | | `diffuseConstant=(symbol)`| (initial, warning)| `` | | `diffuseConstant=(function)`| (initial, warning)| `` | | `diffuseConstant=(null)`| (initial)| `` | @@ -2773,6 +2773,56 @@ | `disabled=(null)`| (initial)| `` | | `disabled=(undefined)`| (initial)| `` | +## `disablePictureInPicture` (on `
`) +| Test Case | Flags | Result | +| --- | --- | --- | +| `disablePictureInPicture=(string)`| (initial)| `` | +| `disablePictureInPicture=(empty string)`| (initial)| `` | +| `disablePictureInPicture=(array with string)`| (initial)| `` | +| `disablePictureInPicture=(empty array)`| (initial)| `` | +| `disablePictureInPicture=(object)`| (initial)| `` | +| `disablePictureInPicture=(numeric string)`| (initial)| `` | +| `disablePictureInPicture=(-1)`| (initial)| `` | +| `disablePictureInPicture=(0)`| (initial)| `` | +| `disablePictureInPicture=(integer)`| (initial)| `` | +| `disablePictureInPicture=(NaN)`| (initial, warning)| `` | +| `disablePictureInPicture=(float)`| (initial)| `` | +| `disablePictureInPicture=(true)`| (initial)| `` | +| `disablePictureInPicture=(false)`| (initial)| `` | +| `disablePictureInPicture=(string 'true')`| (initial, warning)| `` | +| `disablePictureInPicture=(string 'false')`| (initial, warning)| `` | +| `disablePictureInPicture=(string 'on')`| (initial)| `` | +| `disablePictureInPicture=(string 'off')`| (initial)| `` | +| `disablePictureInPicture=(symbol)`| (initial, warning)| `` | +| `disablePictureInPicture=(function)`| (initial, warning)| `` | +| `disablePictureInPicture=(null)`| (initial)| `` | +| `disablePictureInPicture=(undefined)`| (initial)| `` | + +## `disableRemotePlayback` (on `