refactor(eslint-plugin-react-hooks): tidy up type errors

Author: michaelfaith

packages/eslint-plugin-react-hooks/__tests__/ReactCompilerRule-test.ts

@@ -5,17 +5,17 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import {ErrorSeverity} from 'babel-plugin-react-compiler/src';
+import {ErrorSeverity} from 'babel-plugin-react-compiler';
 import {RuleTester as ESLintTester} from 'eslint';
-import ReactCompilerRule from '../src/rules/ReactCompilerRule';
+import ReactCompilerRule from '../src/rules/ReactCompiler';
 
 /**
  * A string template tag that removes padding from the left side of multi-line strings
  * @param {Array} strings array of code strings (only one expected)
  */
 function normalizeIndent(strings: TemplateStringsArray): string {
-  const codeLines = strings[0].split('\n');
-  const leftPadding = codeLines[1].match(/\s+/)![0];
+  const codeLines = strings[0]?.split('\n') ?? [];
+  const leftPadding = codeLines[1]?.match(/\s+/)![0] ?? '';
   return codeLines.map(line => line.slice(leftPadding.length)).join('\n');
 }
 

packages/eslint-plugin-react-hooks/__tests__/ReactCompilerRuleTypescript-test.ts

@@ -6,15 +6,15 @@
  */
 
 import {RuleTester} from 'eslint';
-import ReactCompilerRule from '../src/rules/ReactCompilerRule';
+import ReactCompilerRule from '../src/rules/ReactCompiler';
 
 /**
  * A string template tag that removes padding from the left side of multi-line strings
  * @param {Array} strings array of code strings (only one expected)
  */
 function normalizeIndent(strings: TemplateStringsArray): string {
-  const codeLines = strings[0].split('\n');
-  const leftPadding = codeLines[1].match(/\s+/)[0];
+  const codeLines = strings[0]?.split('\n') ?? [];
+  const leftPadding = codeLines[1]?.match(/\s+/)![0] ?? '';
   return codeLines.map(line => line.slice(leftPadding.length)).join('\n');
 }
 

packages/eslint-plugin-react-hooks/src/index.ts

@@ -4,14 +4,17 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
-import RulesOfHooks from './rules/RulesOfHooks';
-import ExhaustiveDeps from './rules/ExhaustiveDeps';
 import type {ESLint, Linter, Rule} from 'eslint';
 
+import ExhaustiveDeps from './rules/ExhaustiveDeps';
+import ReactCompiler from './rules/ReactCompiler';
+import RulesOfHooks from './rules/RulesOfHooks';
+
 // All rules
 const rules = {
-  'rules-of-hooks': RulesOfHooks,
   'exhaustive-deps': ExhaustiveDeps,
+  'react-compiler': ReactCompiler,
+  'rules-of-hooks': RulesOfHooks,
 } satisfies Record<string, Rule.RuleModule>;
 
 // Config rules

packages/eslint-plugin-react-hooks/src/rules/ReactCompiler.ts

@@ -17,6 +17,7 @@ import BabelPluginReactCompiler, {
   validateEnvironmentConfig,
   OPT_OUT_DIRECTIVES,
   type Logger,
+  type LoggerEvent,
   type PluginOptions,
 } from 'babel-plugin-react-compiler';
 import type {Rule} from 'eslint';
@@ -180,10 +181,10 @@ const rule: Rule.RuleModule = {
               endLoc = {
                 line: event.fnLoc.start.line,
                 // Babel loc line numbers are 1-indexed
-                column: sourceCode.text.split(
-                  /\r?\n|\r|\n/g,
-                  event.fnLoc.start.line,
-                )[event.fnLoc.start.line - 1].length,
+                column:
+                  sourceCode.text.split(/\r?\n|\r|\n/g)[
+                    event.fnLoc.start.line - 1
+                  ]?.length ?? 0,
               };
             }
             const firstLineLoc = {
@@ -226,8 +227,8 @@ const rule: Rule.RuleModule = {
       options.environment = validateEnvironmentConfig(
         options.environment ?? {},
       );
-    } catch (err) {
-      options.logger?.logEvent('', err);
+    } catch (err: unknown) {
+      options.logger?.logEvent('', err as LoggerEvent);
     }
 
     function hasFlowSuppression(

packages/eslint-plugin-react-hooks/tsconfig.json

@@ -12,6 +12,5 @@
       "babel-plugin-react-compiler": ["../../compiler/packages/babel-plugin-react-compiler/src/index.ts"]
     }
   },
-  "exclude": ["node_modules"],
-  "include": ["src/**/*.ts"]
+  "include": ["src/**/*.ts", "__tests__/**/*.ts"]
 }