Skip to content

Commit a031042

Browse files
committed
[Fizz] Outline a Suspense Boundary if it has Suspensey CSS or Images (#34552)
We should favor outlining a boundary if it contains Suspensey CSS or Suspensey Images since then we can load that content separately and not block the main content. This also allows us to animate the reveal. For example this should be able to animate the reveal even though the actual HTML content isn't large in this case it's worth outlining so that the JS runtime can choose to animate this reveal. ```js <ViewTransition> <Suspense> <img src="..." /> </Suspense> </ViewTransition> ``` For Suspensey Images, in Fizz, we currently only implement the suspensey semantics when a View Transition is running. Therefore the outlining only applies if it appears inside a Suspense boundary which might animate. Otherwise there's no point in outlining. It is also only if the Suspense boundary itself might animate its appear and not just any ViewTransition. So the effect is very conservative. For CSS it applies even without ViewTransition though, since it can help unblock the main content faster. DiffTrain build for [6eb5d67](6eb5d67)
1 parent 8669b9e commit a031042

36 files changed

+342
-235
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8ad773b1f342d20e4773c8d086028c6927445a22
1+
6eb5d67e9c4c5c456783dbbd454d79016c43b07d
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8ad773b1f342d20e4773c8d086028c6927445a22
1+
6eb5d67e9c4c5c456783dbbd454d79016c43b07d

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-classic-8ad773b1-20250924";
1422+
exports.version = "19.2.0-www-classic-6eb5d67e-20250925";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ __DEV__ &&
14191419
exports.useTransition = function () {
14201420
return resolveDispatcher().useTransition();
14211421
};
1422-
exports.version = "19.2.0-www-modern-8ad773b1-20250924";
1422+
exports.version = "19.2.0-www-modern-6eb5d67e-20250925";
14231423
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14241424
"function" ===
14251425
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-classic-8ad773b1-20250924";
605+
exports.version = "19.2.0-www-classic-6eb5d67e-20250925";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,4 +602,4 @@ exports.useSyncExternalStore = function (
602602
exports.useTransition = function () {
603603
return ReactSharedInternals.H.useTransition();
604604
};
605-
exports.version = "19.2.0-www-modern-8ad773b1-20250924";
605+
exports.version = "19.2.0-www-modern-6eb5d67e-20250925";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-classic-8ad773b1-20250924";
609+
exports.version = "19.2.0-www-classic-6eb5d67e-20250925";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ exports.useSyncExternalStore = function (
606606
exports.useTransition = function () {
607607
return ReactSharedInternals.H.useTransition();
608608
};
609-
exports.version = "19.2.0-www-modern-8ad773b1-20250924";
609+
exports.version = "19.2.0-www-modern-6eb5d67e-20250925";
610610
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
611611
"function" ===
612612
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20224,10 +20224,10 @@ __DEV__ &&
2022420224
(function () {
2022520225
var internals = {
2022620226
bundleType: 1,
20227-
version: "19.2.0-www-classic-8ad773b1-20250924",
20227+
version: "19.2.0-www-classic-6eb5d67e-20250925",
2022820228
rendererPackageName: "react-art",
2022920229
currentDispatcherRef: ReactSharedInternals,
20230-
reconcilerVersion: "19.2.0-www-classic-8ad773b1-20250924"
20230+
reconcilerVersion: "19.2.0-www-classic-6eb5d67e-20250925"
2023120231
};
2023220232
internals.overrideHookState = overrideHookState;
2023320233
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20261,7 +20261,7 @@ __DEV__ &&
2026120261
exports.Shape = Shape;
2026220262
exports.Surface = Surface;
2026320263
exports.Text = Text;
20264-
exports.version = "19.2.0-www-classic-8ad773b1-20250924";
20264+
exports.version = "19.2.0-www-classic-6eb5d67e-20250925";
2026520265
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2026620266
"function" ===
2026720267
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19995,10 +19995,10 @@ __DEV__ &&
1999519995
(function () {
1999619996
var internals = {
1999719997
bundleType: 1,
19998-
version: "19.2.0-www-modern-8ad773b1-20250924",
19998+
version: "19.2.0-www-modern-6eb5d67e-20250925",
1999919999
rendererPackageName: "react-art",
2000020000
currentDispatcherRef: ReactSharedInternals,
20001-
reconcilerVersion: "19.2.0-www-modern-8ad773b1-20250924"
20001+
reconcilerVersion: "19.2.0-www-modern-6eb5d67e-20250925"
2000220002
};
2000320003
internals.overrideHookState = overrideHookState;
2000420004
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20032,7 +20032,7 @@ __DEV__ &&
2003220032
exports.Shape = Shape;
2003320033
exports.Surface = Surface;
2003420034
exports.Text = Text;
20035-
exports.version = "19.2.0-www-modern-8ad773b1-20250924";
20035+
exports.version = "19.2.0-www-modern-6eb5d67e-20250925";
2003620036
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2003720037
"function" ===
2003820038
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)