Skip to content

Commit 9bc26c8

Browse files
committed
Remove excess ms prop from Suspense tests
These tests now use the built-in cache and the prop was ignored for a while now so I removed them to avoid confusion when reading tests.
1 parent 9ffe910 commit 9bc26c8

5 files changed

+69
-77
lines changed

packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js

+22-22
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ describe('ReactSuspense', () => {
107107
<Suspense fallback={<Text text="Loading..." />}>
108108
{renderBar ? (
109109
<Bar>
110-
<AsyncText text="A" ms={100} />
110+
<AsyncText text="A" />
111111
<Text text="B" />
112112
</Bar>
113113
) : null}
@@ -153,10 +153,10 @@ describe('ReactSuspense', () => {
153153
root.render(
154154
<>
155155
<Suspense fallback={<Text text="Loading A..." />}>
156-
<AsyncText text="A" ms={5000} />
156+
<AsyncText text="A" />
157157
</Suspense>
158158
<Suspense fallback={<Text text="Loading B..." />}>
159-
<AsyncText text="B" ms={6000} />
159+
<AsyncText text="B" />
160160
</Suspense>
161161
</>,
162162
);
@@ -258,9 +258,9 @@ describe('ReactSuspense', () => {
258258
Scheduler.log('Foo');
259259
return (
260260
<Suspense fallback={<Text text="Loading..." />}>
261-
<AsyncText text="A" ms={200} />
261+
<AsyncText text="A" />
262262
<Suspense fallback={<Text text="Loading more..." />}>
263-
<AsyncText text="B" ms={300} />
263+
<AsyncText text="B" />
264264
</Suspense>
265265
</Suspense>
266266
);
@@ -294,9 +294,9 @@ describe('ReactSuspense', () => {
294294
Scheduler.log('Foo');
295295
return (
296296
<Suspense fallback={<Text text="Loading..." />}>
297-
<AsyncText text="A" ms={200} />
297+
<AsyncText text="A" />
298298
<Suspense fallback={<Text text="Loading more..." />}>
299-
<AsyncText text="B" ms={1200} />
299+
<AsyncText text="B" />
300300
</Suspense>
301301
</Suspense>
302302
);
@@ -346,7 +346,7 @@ describe('ReactSuspense', () => {
346346
<>
347347
<Text text={`A${step}`} />
348348
<Suspense fallback={<Text text="Loading..." />}>
349-
{shouldSuspend ? <AsyncText text="Async" ms={2000} /> : null}
349+
{shouldSuspend ? <AsyncText text="Async" /> : null}
350350
</Suspense>
351351
<Text text={`B${step}`} />
352352
<Text text={`C${step}`} />
@@ -627,7 +627,7 @@ describe('ReactSuspense', () => {
627627
return (
628628
<Suspense fallback={<Text text="Loading..." />}>
629629
<TextWithLayout text="Child 1" />
630-
{show && <AsyncText ms={1000} text="Child 2" />}
630+
{show && <AsyncText text="Child 2" />}
631631
</Suspense>
632632
);
633633
}
@@ -722,7 +722,7 @@ describe('ReactSuspense', () => {
722722
return (
723723
<Suspense fallback={<TextWithLifecycle text="Loading..." />}>
724724
<TextWithLifecycle text="A" />
725-
<AsyncTextWithLifecycle ms={100} text="B" ref={instance} />
725+
<AsyncTextWithLifecycle text="B" ref={instance} />
726726
<TextWithLifecycle text="C" />
727727
</Suspense>
728728
);
@@ -776,7 +776,7 @@ describe('ReactSuspense', () => {
776776
return (
777777
<Suspense fallback={<Text text="Loading..." />}>
778778
<Stateful />
779-
<AsyncText ms={1000} text={props.text} />
779+
<AsyncText text={props.text} />
780780
</Suspense>
781781
);
782782
}
@@ -822,7 +822,7 @@ describe('ReactSuspense', () => {
822822
<Indirection>
823823
<Indirection>
824824
<Indirection>
825-
<AsyncText ms={1000} text={props.text} />
825+
<AsyncText text={props.text} />
826826
</Indirection>
827827
</Indirection>
828828
</Indirection>
@@ -872,7 +872,7 @@ describe('ReactSuspense', () => {
872872
function App({text}) {
873873
return (
874874
<Suspense fallback={<Text text="Loading..." />}>
875-
<AsyncTextWithUnmount text={text} ms={100} />
875+
<AsyncTextWithUnmount text={text} />
876876
</Suspense>
877877
);
878878
}
@@ -902,7 +902,7 @@ describe('ReactSuspense', () => {
902902
function App({text}) {
903903
return (
904904
<Suspense fallback={<Text text="Loading..." />}>
905-
<AsyncTextWithEffect text={text} ms={100} />
905+
<AsyncTextWithEffect text={text} />
906906
</Suspense>
907907
);
908908
}
@@ -920,7 +920,7 @@ describe('ReactSuspense', () => {
920920
state = {step: 1};
921921
render() {
922922
instance = this;
923-
return <AsyncText ms={1000} text={`Step: ${this.state.step}`} />;
923+
return <AsyncText text={`Step: ${this.state.step}`} />;
924924
}
925925
}
926926

@@ -976,9 +976,9 @@ describe('ReactSuspense', () => {
976976
function App(props) {
977977
return (
978978
<Suspense fallback={<ShouldMountOnce />}>
979-
<AsyncText ms={1000} text="Child 1" />
980-
<AsyncText ms={2000} text="Child 2" />
981-
<AsyncText ms={3000} text="Child 3" />
979+
<AsyncText text="Child 1" />
980+
<AsyncText text="Child 2" />
981+
<AsyncText text="Child 3" />
982982
</Suspense>
983983
);
984984
}
@@ -1019,7 +1019,7 @@ describe('ReactSuspense', () => {
10191019

10201020
return (
10211021
<Suspense fallback={<Text text="Loading..." />}>
1022-
<AsyncText key={tab} text={'Tab: ' + tab} ms={1000} />
1022+
<AsyncText key={tab} text={'Tab: ' + tab} />
10231023
<Text key={tab + 'sibling'} text=" + sibling" />
10241024
</Suspense>
10251025
);
@@ -1087,9 +1087,9 @@ describe('ReactSuspense', () => {
10871087
function App() {
10881088
return (
10891089
<Suspense fallback={<Text text="Loading..." />}>
1090-
<AsyncText text="A" ms={1000} />
1091-
<AsyncText text="B" ms={2000} />
1092-
<AsyncText text="C" ms={3000} />
1090+
<AsyncText text="A" />
1091+
<AsyncText text="B" />
1092+
<AsyncText text="C" />
10931093
</Suspense>
10941094
);
10951095
}

0 commit comments

Comments
 (0)