From 8bc95bb3c8c975d650161e472de4d8a92d9a92fd Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Tue, 4 Oct 2022 11:39:25 -0400 Subject: [PATCH] Flow upgrade to 0.154 ghstack-source-id: d84024950a249f209db88be6788b80f7fa4f26d0 Pull Request resolved: https://github.com/facebook/react/pull/25413 --- package.json | 2 +- .../src/devtools/views/Components/KeyValue.js | 2 +- .../src/devtools/views/Profiler/Updaters.js | 2 +- .../react-native-renderer/src/ReactFabricHostConfig.js | 1 + .../src/ReactNativeFiberHostComponent.js | 1 + packages/shared/objectIs.js | 1 + scripts/flow/config/flowconfig | 2 +- yarn.lock | 8 ++++---- 8 files changed, 11 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index ce16ee3811c7e..3c61d53d123b6 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,7 @@ "eslint-plugin-react-internal": "link:./scripts/eslint-rules", "fbjs-scripts": "1.2.0", "filesize": "^6.0.1", - "flow-bin": "^0.153.0", + "flow-bin": "^0.154.0", "glob": "^7.1.6", "glob-stream": "^6.1.0", "google-closure-compiler": "^20200517.0.0", diff --git a/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js b/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js index 592cdb52b94c4..9f2c9160d3ae1 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js @@ -411,7 +411,7 @@ export default function KeyValue({ const hasChildren = entries.length > 0 || canEditValues; const displayName = getMetaValueLabel(value); - children = entries.map>(([key, keyValue]) => ( + children = entries.map(([key, keyValue]): ReactElement => ( 0 ? ( - updaters.map((serializedElement: SerializedElement) => { + updaters.map((serializedElement: SerializedElement): React$Node => { const {displayName, id, key, type} = serializedElement; const isVisibleInTree = commitTree.nodes.has(id) && type !== ElementTypeRoot; diff --git a/packages/react-native-renderer/src/ReactFabricHostConfig.js b/packages/react-native-renderer/src/ReactFabricHostConfig.js index 868eaaab48d50..c0d17b3c24129 100644 --- a/packages/react-native-renderer/src/ReactFabricHostConfig.js +++ b/packages/react-native-renderer/src/ReactFabricHostConfig.js @@ -317,6 +317,7 @@ class ReactFabricHostComponent { // eslint-disable-next-line no-unused-expressions // $FlowFixMe[class-object-subtyping] found when upgrading Flow +// $FlowFixMe[method-unbinding] found when upgrading Flow (ReactFabricHostComponent.prototype: $ReadOnly<{...NativeMethods, ...}>); export * from 'react-reconciler/src/ReactFiberHostConfigWithNoMutation'; diff --git a/packages/react-native-renderer/src/ReactNativeFiberHostComponent.js b/packages/react-native-renderer/src/ReactNativeFiberHostComponent.js index 3f3cf1540f962..548f588680431 100644 --- a/packages/react-native-renderer/src/ReactNativeFiberHostComponent.js +++ b/packages/react-native-renderer/src/ReactNativeFiberHostComponent.js @@ -128,6 +128,7 @@ class ReactNativeFiberHostComponent { // eslint-disable-next-line no-unused-expressions // $FlowFixMe[class-object-subtyping] found when upgrading Flow +// $FlowFixMe[method-unbinding] found when upgrading Flow (ReactNativeFiberHostComponent.prototype: $ReadOnly<{...NativeMethods, ...}>); export default ReactNativeFiberHostComponent; diff --git a/packages/shared/objectIs.js b/packages/shared/objectIs.js index f83b5c2838b0e..9fd10592dbe9e 100644 --- a/packages/shared/objectIs.js +++ b/packages/shared/objectIs.js @@ -18,6 +18,7 @@ function is(x: any, y: any) { } const objectIs: (x: any, y: any) => boolean = + // $FlowFixMe[method-unbinding] typeof Object.is === 'function' ? Object.is : is; export default objectIs; diff --git a/scripts/flow/config/flowconfig b/scripts/flow/config/flowconfig index 9f498d2af55c1..4dbf5dfa8e601 100644 --- a/scripts/flow/config/flowconfig +++ b/scripts/flow/config/flowconfig @@ -47,4 +47,4 @@ munge_underscores=false %REACT_RENDERER_FLOW_OPTIONS% [version] -^0.153.0 +^0.154.0 diff --git a/yarn.lock b/yarn.lock index 9dd6c9e3b8eb8..90312a8c30d4b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7912,10 +7912,10 @@ flatted@^2.0.0: resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138" integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA== -flow-bin@^0.153.0: - version "0.153.0" - resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.153.0.tgz#44d941acaf5ef977fa26d1b4b5dc3cf56b68eefc" - integrity sha512-sxP9nfXnoyCUT6hjAO+zDyHLO3dZcWg0h+4HttHs/5wg/2oAkTDwmsWbj095IQsEmwTicq2TfqWq5QRuLxynlQ== +flow-bin@^0.154.0: + version "0.154.0" + resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.154.0.tgz#e086964398e671daa8f56ed8663d7876337f77e5" + integrity sha512-I6u2ETdkAyard+8C5na6bfZp4EM0zIMB7O5zH4GKzBLv9/y8/NYRTxEXQe5T0hvj9R9DxFBUoPsFK76ziweUFw== fluent-syntax@0.13.0: version "0.13.0"