Skip to content

Commit 8506f82

Browse files
kassenskassens
committed
Remove unused returnFiber (#28504)
There is no use of `returnFiber` here, it can be removed. DiffTrain build for [64f354c](64f354c)
1 parent 401192f commit 8506f82

19 files changed

+113
-113
lines changed

‎compiled/facebook-www/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
c11b196ae3e2e3c5d143d9102b35a6b6fa97c849
1+
64f354cf27a17c4e5b0dfcd908e47940cf947771

‎compiled/facebook-www/React-prod.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
633633
exports.useTransition = function () {
634634
return ReactCurrentDispatcher.current.useTransition();
635635
};
636-
exports.version = "18.3.0-www-classic-5741f0db";
636+
exports.version = "18.3.0-www-classic-8c94b449";

‎compiled/facebook-www/React-profiling.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ exports.useSyncExternalStore = function (
637637
exports.useTransition = function () {
638638
return ReactCurrentDispatcher.current.useTransition();
639639
};
640-
exports.version = "18.3.0-www-classic-6ddd4df1";
640+
exports.version = "18.3.0-www-classic-b219bf7d";
641641
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
642642
"function" ===
643643
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-14143ab0";
69+
var ReactVersion = "18.3.0-www-classic-81c495cd";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -6652,7 +6652,7 @@ if (__DEV__) {
66526652
return null;
66536653
}
66546654

6655-
function mapRemainingChildren(returnFiber, currentFirstChild) {
6655+
function mapRemainingChildren(currentFirstChild) {
66566656
// Add the remaining children to a temporary map so that we can find them by
66576657
// keys quickly. Implicit (null) keys get added to this set with their index
66586658
// instead.
@@ -7432,7 +7432,7 @@ if (__DEV__) {
74327432
return resultingFirstChild;
74337433
} // Add all children to a key map for quick lookups.
74347434

7435-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
7435+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
74367436

74377437
for (; newIdx < newChildren.length; newIdx++) {
74387438
var _newFiber2 = updateFromMap(
@@ -7652,7 +7652,7 @@ if (__DEV__) {
76527652
return resultingFirstChild;
76537653
} // Add all children to a key map for quick lookups.
76547654

7655-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
7655+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
76567656

76577657
for (; !step.done; newIdx++, step = newChildren.next()) {
76587658
var _newFiber4 = updateFromMap(

‎compiled/facebook-www/ReactART-dev.modern.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-0883d4be";
69+
var ReactVersion = "18.3.0-www-modern-c4d09ac8";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -6417,7 +6417,7 @@ if (__DEV__) {
64176417
return null;
64186418
}
64196419

6420-
function mapRemainingChildren(returnFiber, currentFirstChild) {
6420+
function mapRemainingChildren(currentFirstChild) {
64216421
// Add the remaining children to a temporary map so that we can find them by
64226422
// keys quickly. Implicit (null) keys get added to this set with their index
64236423
// instead.
@@ -7197,7 +7197,7 @@ if (__DEV__) {
71977197
return resultingFirstChild;
71987198
} // Add all children to a key map for quick lookups.
71997199

7200-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
7200+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
72017201

72027202
for (; newIdx < newChildren.length; newIdx++) {
72037203
var _newFiber2 = updateFromMap(
@@ -7417,7 +7417,7 @@ if (__DEV__) {
74177417
return resultingFirstChild;
74187418
} // Add all children to a key map for quick lookups.
74197419

7420-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
7420+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
74217421

74227422
for (; !step.done; newIdx++, step = newChildren.next()) {
74237423
var _newFiber4 = updateFromMap(

‎compiled/facebook-www/ReactART-prod.classic.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -1913,13 +1913,13 @@ function createChildReconciler(shouldTrackSideEffects) {
19131913
(currentFirstChild = currentFirstChild.sibling);
19141914
return null;
19151915
}
1916-
function mapRemainingChildren(returnFiber, currentFirstChild) {
1917-
for (returnFiber = new Map(); null !== currentFirstChild; )
1916+
function mapRemainingChildren(currentFirstChild) {
1917+
for (var existingChildren = new Map(); null !== currentFirstChild; )
19181918
null !== currentFirstChild.key
1919-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
1920-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
1919+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
1920+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
19211921
(currentFirstChild = currentFirstChild.sibling);
1922-
return returnFiber;
1922+
return existingChildren;
19231923
}
19241924
function useFiber(fiber, pendingProps) {
19251925
fiber = createWorkInProgress(fiber, pendingProps);
@@ -2268,7 +2268,7 @@ function createChildReconciler(shouldTrackSideEffects) {
22682268
return resultingFirstChild;
22692269
}
22702270
for (
2271-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2271+
oldFiber = mapRemainingChildren(oldFiber);
22722272
newIdx < newChildren.length;
22732273
newIdx++
22742274
)
@@ -2353,7 +2353,7 @@ function createChildReconciler(shouldTrackSideEffects) {
23532353
return iteratorFn;
23542354
}
23552355
for (
2356-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2356+
oldFiber = mapRemainingChildren(oldFiber);
23572357
!step.done;
23582358
newIdx++, step = newChildrenIterable.next()
23592359
)
@@ -10600,7 +10600,7 @@ var slice = Array.prototype.slice,
1060010600
return null;
1060110601
},
1060210602
bundleType: 0,
10603-
version: "18.3.0-www-classic-cad557f7",
10603+
version: "18.3.0-www-classic-988117e8",
1060410604
rendererPackageName: "react-art"
1060510605
};
1060610606
var internals$jscomp$inline_1320 = {
@@ -10631,7 +10631,7 @@ var internals$jscomp$inline_1320 = {
1063110631
scheduleRoot: null,
1063210632
setRefreshHandler: null,
1063310633
getCurrentFiber: null,
10634-
reconcilerVersion: "18.3.0-www-classic-cad557f7"
10634+
reconcilerVersion: "18.3.0-www-classic-988117e8"
1063510635
};
1063610636
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1063710637
var hook$jscomp$inline_1321 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactART-prod.modern.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -1709,13 +1709,13 @@ function createChildReconciler(shouldTrackSideEffects) {
17091709
(currentFirstChild = currentFirstChild.sibling);
17101710
return null;
17111711
}
1712-
function mapRemainingChildren(returnFiber, currentFirstChild) {
1713-
for (returnFiber = new Map(); null !== currentFirstChild; )
1712+
function mapRemainingChildren(currentFirstChild) {
1713+
for (var existingChildren = new Map(); null !== currentFirstChild; )
17141714
null !== currentFirstChild.key
1715-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
1716-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
1715+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
1716+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
17171717
(currentFirstChild = currentFirstChild.sibling);
1718-
return returnFiber;
1718+
return existingChildren;
17191719
}
17201720
function useFiber(fiber, pendingProps) {
17211721
fiber = createWorkInProgress(fiber, pendingProps);
@@ -2064,7 +2064,7 @@ function createChildReconciler(shouldTrackSideEffects) {
20642064
return resultingFirstChild;
20652065
}
20662066
for (
2067-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2067+
oldFiber = mapRemainingChildren(oldFiber);
20682068
newIdx < newChildren.length;
20692069
newIdx++
20702070
)
@@ -2149,7 +2149,7 @@ function createChildReconciler(shouldTrackSideEffects) {
21492149
return iteratorFn;
21502150
}
21512151
for (
2152-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2152+
oldFiber = mapRemainingChildren(oldFiber);
21532153
!step.done;
21542154
newIdx++, step = newChildrenIterable.next()
21552155
)
@@ -10255,7 +10255,7 @@ var slice = Array.prototype.slice,
1025510255
return null;
1025610256
},
1025710257
bundleType: 0,
10258-
version: "18.3.0-www-modern-5c2d3ed7",
10258+
version: "18.3.0-www-modern-86dc6ab7",
1025910259
rendererPackageName: "react-art"
1026010260
};
1026110261
var internals$jscomp$inline_1300 = {
@@ -10286,7 +10286,7 @@ var internals$jscomp$inline_1300 = {
1028610286
scheduleRoot: null,
1028710287
setRefreshHandler: null,
1028810288
getCurrentFiber: null,
10289-
reconcilerVersion: "18.3.0-www-modern-5c2d3ed7"
10289+
reconcilerVersion: "18.3.0-www-modern-86dc6ab7"
1029010290
};
1029110291
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1029210292
var hook$jscomp$inline_1301 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -11376,7 +11376,7 @@ if (__DEV__) {
1137611376
return null;
1137711377
}
1137811378

11379-
function mapRemainingChildren(returnFiber, currentFirstChild) {
11379+
function mapRemainingChildren(currentFirstChild) {
1138011380
// Add the remaining children to a temporary map so that we can find them by
1138111381
// keys quickly. Implicit (null) keys get added to this set with their index
1138211382
// instead.
@@ -12166,7 +12166,7 @@ if (__DEV__) {
1216612166
return resultingFirstChild;
1216712167
} // Add all children to a key map for quick lookups.
1216812168

12169-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
12169+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1217012170

1217112171
for (; newIdx < newChildren.length; newIdx++) {
1217212172
var _newFiber2 = updateFromMap(
@@ -12401,7 +12401,7 @@ if (__DEV__) {
1240112401
return resultingFirstChild;
1240212402
} // Add all children to a key map for quick lookups.
1240312403

12404-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
12404+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1240512405

1240612406
for (; !step.done; newIdx++, step = newChildren.next()) {
1240712407
var _newFiber4 = updateFromMap(
@@ -36034,7 +36034,7 @@ if (__DEV__) {
3603436034
return root;
3603536035
}
3603636036

36037-
var ReactVersion = "18.3.0-www-classic-78291ba2";
36037+
var ReactVersion = "18.3.0-www-classic-3e5b27d2";
3603836038

3603936039
function createPortal$1(
3604036040
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -11338,7 +11338,7 @@ if (__DEV__) {
1133811338
return null;
1133911339
}
1134011340

11341-
function mapRemainingChildren(returnFiber, currentFirstChild) {
11341+
function mapRemainingChildren(currentFirstChild) {
1134211342
// Add the remaining children to a temporary map so that we can find them by
1134311343
// keys quickly. Implicit (null) keys get added to this set with their index
1134411344
// instead.
@@ -12128,7 +12128,7 @@ if (__DEV__) {
1212812128
return resultingFirstChild;
1212912129
} // Add all children to a key map for quick lookups.
1213012130

12131-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
12131+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1213212132

1213312133
for (; newIdx < newChildren.length; newIdx++) {
1213412134
var _newFiber2 = updateFromMap(
@@ -12363,7 +12363,7 @@ if (__DEV__) {
1236312363
return resultingFirstChild;
1236412364
} // Add all children to a key map for quick lookups.
1236512365

12366-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
12366+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1236712367

1236812368
for (; !step.done; newIdx++, step = newChildren.next()) {
1236912369
var _newFiber4 = updateFromMap(
@@ -35881,7 +35881,7 @@ if (__DEV__) {
3588135881
return root;
3588235882
}
3588335883

35884-
var ReactVersion = "18.3.0-www-modern-8a38254f";
35884+
var ReactVersion = "18.3.0-www-modern-b7723bc0";
3588535885

3588635886
function createPortal$1(
3588735887
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -2646,13 +2646,13 @@ function createChildReconciler(shouldTrackSideEffects) {
26462646
(currentFirstChild = currentFirstChild.sibling);
26472647
return null;
26482648
}
2649-
function mapRemainingChildren(returnFiber, currentFirstChild) {
2650-
for (returnFiber = new Map(); null !== currentFirstChild; )
2649+
function mapRemainingChildren(currentFirstChild) {
2650+
for (var existingChildren = new Map(); null !== currentFirstChild; )
26512651
null !== currentFirstChild.key
2652-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
2653-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
2652+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
2653+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
26542654
(currentFirstChild = currentFirstChild.sibling);
2655-
return returnFiber;
2655+
return existingChildren;
26562656
}
26572657
function useFiber(fiber, pendingProps) {
26582658
fiber = createWorkInProgress(fiber, pendingProps);
@@ -3004,7 +3004,7 @@ function createChildReconciler(shouldTrackSideEffects) {
30043004
return resultingFirstChild;
30053005
}
30063006
for (
3007-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3007+
oldFiber = mapRemainingChildren(oldFiber);
30083008
newIdx < newChildren.length;
30093009
newIdx++
30103010
)
@@ -3095,7 +3095,7 @@ function createChildReconciler(shouldTrackSideEffects) {
30953095
return iteratorFn;
30963096
}
30973097
for (
3098-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3098+
oldFiber = mapRemainingChildren(oldFiber);
30993099
!step.done;
31003100
newIdx++, step = newChildrenIterable.next()
31013101
)
@@ -17237,7 +17237,7 @@ Internals.Events = [
1723717237
var devToolsConfig$jscomp$inline_1822 = {
1723817238
findFiberByHostInstance: getClosestInstanceFromNode,
1723917239
bundleType: 0,
17240-
version: "18.3.0-www-classic-513335d7",
17240+
version: "18.3.0-www-classic-caa15134",
1724117241
rendererPackageName: "react-dom"
1724217242
};
1724317243
var internals$jscomp$inline_2181 = {
@@ -17267,7 +17267,7 @@ var internals$jscomp$inline_2181 = {
1726717267
scheduleRoot: null,
1726817268
setRefreshHandler: null,
1726917269
getCurrentFiber: null,
17270-
reconcilerVersion: "18.3.0-www-classic-513335d7"
17270+
reconcilerVersion: "18.3.0-www-classic-caa15134"
1727117271
};
1727217272
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1727317273
var hook$jscomp$inline_2182 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17598,4 +17598,4 @@ exports.useFormState = function (action, initialState, permalink) {
1759817598
exports.useFormStatus = function () {
1759917599
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1760017600
};
17601-
exports.version = "18.3.0-www-classic-513335d7";
17601+
exports.version = "18.3.0-www-classic-caa15134";

‎compiled/facebook-www/ReactDOM-prod.modern.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -2540,13 +2540,13 @@ function createChildReconciler(shouldTrackSideEffects) {
25402540
(currentFirstChild = currentFirstChild.sibling);
25412541
return null;
25422542
}
2543-
function mapRemainingChildren(returnFiber, currentFirstChild) {
2544-
for (returnFiber = new Map(); null !== currentFirstChild; )
2543+
function mapRemainingChildren(currentFirstChild) {
2544+
for (var existingChildren = new Map(); null !== currentFirstChild; )
25452545
null !== currentFirstChild.key
2546-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
2547-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
2546+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
2547+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
25482548
(currentFirstChild = currentFirstChild.sibling);
2549-
return returnFiber;
2549+
return existingChildren;
25502550
}
25512551
function useFiber(fiber, pendingProps) {
25522552
fiber = createWorkInProgress(fiber, pendingProps);
@@ -2898,7 +2898,7 @@ function createChildReconciler(shouldTrackSideEffects) {
28982898
return resultingFirstChild;
28992899
}
29002900
for (
2901-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2901+
oldFiber = mapRemainingChildren(oldFiber);
29022902
newIdx < newChildren.length;
29032903
newIdx++
29042904
)
@@ -2989,7 +2989,7 @@ function createChildReconciler(shouldTrackSideEffects) {
29892989
return iteratorFn;
29902990
}
29912991
for (
2992-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
2992+
oldFiber = mapRemainingChildren(oldFiber);
29932993
!step.done;
29942994
newIdx++, step = newChildrenIterable.next()
29952995
)
@@ -16753,7 +16753,7 @@ Internals.Events = [
1675316753
var devToolsConfig$jscomp$inline_1781 = {
1675416754
findFiberByHostInstance: getClosestInstanceFromNode,
1675516755
bundleType: 0,
16756-
version: "18.3.0-www-modern-f13b626a",
16756+
version: "18.3.0-www-modern-2a863e2d",
1675716757
rendererPackageName: "react-dom"
1675816758
};
1675916759
var internals$jscomp$inline_2145 = {
@@ -16784,7 +16784,7 @@ var internals$jscomp$inline_2145 = {
1678416784
scheduleRoot: null,
1678516785
setRefreshHandler: null,
1678616786
getCurrentFiber: null,
16787-
reconcilerVersion: "18.3.0-www-modern-f13b626a"
16787+
reconcilerVersion: "18.3.0-www-modern-2a863e2d"
1678816788
};
1678916789
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1679016790
var hook$jscomp$inline_2146 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17043,4 +17043,4 @@ exports.useFormState = function (action, initialState, permalink) {
1704317043
exports.useFormStatus = function () {
1704417044
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1704517045
};
17046-
exports.version = "18.3.0-www-modern-f13b626a";
17046+
exports.version = "18.3.0-www-modern-2a863e2d";

0 commit comments

Comments
 (0)