Skip to content

Commit 41b4714

Browse files
authored
Remove disableNativeComponentFrames (#26490)
## Overview I'm landing this flag internally so we can delete this
1 parent fc90eb6 commit 41b4714

9 files changed

+2
-14
lines changed

packages/shared/ReactComponentStackFrame.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import type {Source} from 'shared/ReactElementType';
1111
import type {LazyComponent} from 'react/src/ReactLazy';
1212

13-
import {
14-
enableComponentStackLocations,
15-
disableNativeComponentFrames,
16-
} from 'shared/ReactFeatureFlags';
13+
import {enableComponentStackLocations} from 'shared/ReactFeatureFlags';
1714

1815
import {
1916
REACT_SUSPENSE_TYPE,
@@ -68,7 +65,7 @@ export function describeNativeComponentFrame(
6865
construct: boolean,
6966
): string {
7067
// If something asked for a stack inside a fake render, it should get ignored.
71-
if (disableNativeComponentFrames || !fn || reentry) {
68+
if (!fn || reentry) {
7269
return '';
7370
}
7471

packages/shared/ReactFeatureFlags.js

-2
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,6 @@ export const enableDebugTracing = false;
230230
// Track which Fiber(s) schedule render work.
231231
export const enableUpdaterTracking = __PROFILE__;
232232

233-
// Only enabled in RN, related to enableComponentStackLocations
234-
export const disableNativeComponentFrames = false;
235233
export const enableServerContext = true;
236234

237235
// Internal only.

packages/shared/forks/ReactFeatureFlags.native-fb.js

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
5858
export const enableComponentStackLocations = false;
5959
export const enableLegacyFBSupport = false;
6060
export const enableFilterEmptyStringAttributesDOM = false;
61-
export const disableNativeComponentFrames = false;
6261
export const skipUnmountedBoundaries = false;
6362
export const enableGetInspectorDataForInstanceInProduction = true;
6463
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4848
export const enableComponentStackLocations = false;
4949
export const enableLegacyFBSupport = false;
5050
export const enableFilterEmptyStringAttributesDOM = false;
51-
export const disableNativeComponentFrames = false;
5251
export const skipUnmountedBoundaries = false;
5352
export const enableGetInspectorDataForInstanceInProduction = false;
5453
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4848
export const enableComponentStackLocations = true;
4949
export const enableLegacyFBSupport = false;
5050
export const enableFilterEmptyStringAttributesDOM = false;
51-
export const disableNativeComponentFrames = false;
5251
export const skipUnmountedBoundaries = false;
5352
export const enableGetInspectorDataForInstanceInProduction = false;
5453
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ export const disableModulePatternComponents = false;
3939
export const enableComponentStackLocations = false;
4040
export const enableLegacyFBSupport = false;
4141
export const enableFilterEmptyStringAttributesDOM = false;
42-
export const disableNativeComponentFrames = false;
4342
export const skipUnmountedBoundaries = false;
4443
export const enableGetInspectorDataForInstanceInProduction = false;
4544
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4848
export const enableComponentStackLocations = true;
4949
export const enableLegacyFBSupport = false;
5050
export const enableFilterEmptyStringAttributesDOM = true;
51-
export const disableNativeComponentFrames = false;
5251
export const skipUnmountedBoundaries = false;
5352
export const enableGetInspectorDataForInstanceInProduction = false;
5453
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

-1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,5 @@ export const revertRemovalOfSiblingPrerendering = false;
5959
// Update the tests so that they pass in either mode, then set these
6060
// to __VARIANT__.
6161
export const enableTrustedTypesIntegration = false;
62-
export const disableNativeComponentFrames = false;
6362
// You probably *don't* want to add more hardcoded ones.
6463
// Instead, try to add them above with the __VARIANT__ value.

packages/shared/forks/ReactFeatureFlags.www.js

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export const {
2525
enableDebugTracing,
2626
skipUnmountedBoundaries,
2727
enableUseRefAccessWarning,
28-
disableNativeComponentFrames,
2928
disableSchedulerTimeoutInWorkLoop,
3029
enableLazyContextPropagation,
3130
enableUnifiedSyncLane,

0 commit comments

Comments
 (0)