Skip to content

Commit 40686cd

Browse files
kassenskassens
committed
Remove unused returnFiber (#28504)
There is no use of `returnFiber` here, it can be removed. DiffTrain build for commit 64f354c.
1 parent 1750eca commit 40686cd

File tree

13 files changed

+79
-79
lines changed

13 files changed

+79
-79
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bc3ffb1cb29e8a4af3d060e1e199ebfc>>
10+
* @generated SignedSource<<85c861db7cfef261bb2c4cf3c4163b32>>
1111
*/
1212

1313
"use strict";
@@ -5307,7 +5307,7 @@ if (__DEV__) {
53075307
return null;
53085308
}
53095309

5310-
function mapRemainingChildren(returnFiber, currentFirstChild) {
5310+
function mapRemainingChildren(currentFirstChild) {
53115311
// Add the remaining children to a temporary map so that we can find them by
53125312
// keys quickly. Implicit (null) keys get added to this set with their index
53135313
// instead.
@@ -6087,7 +6087,7 @@ if (__DEV__) {
60876087
return resultingFirstChild;
60886088
} // Add all children to a key map for quick lookups.
60896089

6090-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
6090+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
60916091

60926092
for (; newIdx < newChildren.length; newIdx++) {
60936093
var _newFiber2 = updateFromMap(
@@ -6307,7 +6307,7 @@ if (__DEV__) {
63076307
return resultingFirstChild;
63086308
} // Add all children to a key map for quick lookups.
63096309

6310-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
6310+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
63116311

63126312
for (; !step.done; newIdx++, step = newChildren.next()) {
63136313
var _newFiber4 = updateFromMap(
@@ -25736,7 +25736,7 @@ if (__DEV__) {
2573625736
return root;
2573725737
}
2573825738

25739-
var ReactVersion = "18.3.0-canary-0066e0b68-20240306";
25739+
var ReactVersion = "18.3.0-canary-64f354cf2-20240306";
2574025740

2574125741
// Might add PROFILE later.
2574225742

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ae8df36bd7abef975eb0e74298e0e1bb>>
10+
* @generated SignedSource<<0b3d2b1f18482dd826567f1832971cb5>>
1111
*/
1212

1313
"use strict";
@@ -1533,13 +1533,13 @@ function createChildReconciler(shouldTrackSideEffects) {
15331533
(currentFirstChild = currentFirstChild.sibling);
15341534
return null;
15351535
}
1536-
function mapRemainingChildren(returnFiber, currentFirstChild) {
1537-
for (returnFiber = new Map(); null !== currentFirstChild; )
1536+
function mapRemainingChildren(currentFirstChild) {
1537+
for (var existingChildren = new Map(); null !== currentFirstChild; )
15381538
null !== currentFirstChild.key
1539-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
1540-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
1539+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
1540+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
15411541
(currentFirstChild = currentFirstChild.sibling);
1542-
return returnFiber;
1542+
return existingChildren;
15431543
}
15441544
function useFiber(fiber, pendingProps) {
15451545
fiber = createWorkInProgress(fiber, pendingProps);
@@ -1888,7 +1888,7 @@ function createChildReconciler(shouldTrackSideEffects) {
18881888
return resultingFirstChild;
18891889
}
18901890
for (
1891-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
1891+
oldFiber = mapRemainingChildren(oldFiber);
18921892
newIdx < newChildren.length;
18931893
newIdx++
18941894
)
@@ -1976,7 +1976,7 @@ function createChildReconciler(shouldTrackSideEffects) {
19761976
return iteratorFn;
19771977
}
19781978
for (
1979-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
1979+
oldFiber = mapRemainingChildren(oldFiber);
19801980
!step.done;
19811981
newIdx++, step = newChildrenIterable.next()
19821982
)
@@ -9178,7 +9178,7 @@ var devToolsConfig$jscomp$inline_1014 = {
91789178
throw Error("TestRenderer does not support findFiberByHostInstance()");
91799179
},
91809180
bundleType: 0,
9181-
version: "18.3.0-canary-0066e0b68-20240306",
9181+
version: "18.3.0-canary-64f354cf2-20240306",
91829182
rendererPackageName: "react-test-renderer"
91839183
};
91849184
var internals$jscomp$inline_1195 = {
@@ -9209,7 +9209,7 @@ var internals$jscomp$inline_1195 = {
92099209
scheduleRoot: null,
92109210
setRefreshHandler: null,
92119211
getCurrentFiber: null,
9212-
reconcilerVersion: "18.3.0-canary-0066e0b68-20240306"
9212+
reconcilerVersion: "18.3.0-canary-64f354cf2-20240306"
92139213
};
92149214
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
92159215
var hook$jscomp$inline_1196 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<468afdc5511d0a33f94018471424df06>>
10+
* @generated SignedSource<<7593cf403d3fbcc1c9b517d40ffc9701>>
1111
*/
1212

1313
"use strict";
@@ -1553,13 +1553,13 @@ function createChildReconciler(shouldTrackSideEffects) {
15531553
(currentFirstChild = currentFirstChild.sibling);
15541554
return null;
15551555
}
1556-
function mapRemainingChildren(returnFiber, currentFirstChild) {
1557-
for (returnFiber = new Map(); null !== currentFirstChild; )
1556+
function mapRemainingChildren(currentFirstChild) {
1557+
for (var existingChildren = new Map(); null !== currentFirstChild; )
15581558
null !== currentFirstChild.key
1559-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
1560-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
1559+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
1560+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
15611561
(currentFirstChild = currentFirstChild.sibling);
1562-
return returnFiber;
1562+
return existingChildren;
15631563
}
15641564
function useFiber(fiber, pendingProps) {
15651565
fiber = createWorkInProgress(fiber, pendingProps);
@@ -1908,7 +1908,7 @@ function createChildReconciler(shouldTrackSideEffects) {
19081908
return resultingFirstChild;
19091909
}
19101910
for (
1911-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
1911+
oldFiber = mapRemainingChildren(oldFiber);
19121912
newIdx < newChildren.length;
19131913
newIdx++
19141914
)
@@ -1996,7 +1996,7 @@ function createChildReconciler(shouldTrackSideEffects) {
19961996
return iteratorFn;
19971997
}
19981998
for (
1999-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
1999+
oldFiber = mapRemainingChildren(oldFiber);
20002000
!step.done;
20012001
newIdx++, step = newChildrenIterable.next()
20022002
)
@@ -9606,7 +9606,7 @@ var devToolsConfig$jscomp$inline_1056 = {
96069606
throw Error("TestRenderer does not support findFiberByHostInstance()");
96079607
},
96089608
bundleType: 0,
9609-
version: "18.3.0-canary-0066e0b68-20240306",
9609+
version: "18.3.0-canary-64f354cf2-20240306",
96109610
rendererPackageName: "react-test-renderer"
96119611
};
96129612
var internals$jscomp$inline_1236 = {
@@ -9637,7 +9637,7 @@ var internals$jscomp$inline_1236 = {
96379637
scheduleRoot: null,
96389638
setRefreshHandler: null,
96399639
getCurrentFiber: null,
9640-
reconcilerVersion: "18.3.0-canary-0066e0b68-20240306"
9640+
reconcilerVersion: "18.3.0-canary-64f354cf2-20240306"
96419641
};
96429642
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96439643
var hook$jscomp$inline_1237 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (__DEV__) {
2626
}
2727
var dynamicFlags = require("ReactNativeInternalFeatureFlags");
2828

29-
var ReactVersion = "18.3.0-canary-0066e0b68-20240306";
29+
var ReactVersion = "18.3.0-canary-64f354cf2-20240306";
3030

3131
// ATTENTION
3232
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -598,4 +598,4 @@ exports.useSyncExternalStore = function (
598598
exports.useTransition = function () {
599599
return ReactCurrentDispatcher.current.useTransition();
600600
};
601-
exports.version = "18.3.0-canary-0066e0b68-20240306";
601+
exports.version = "18.3.0-canary-64f354cf2-20240306";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ exports.useSyncExternalStore = function (
594594
exports.useTransition = function () {
595595
return ReactCurrentDispatcher.current.useTransition();
596596
};
597-
exports.version = "18.3.0-canary-0066e0b68-20240306";
597+
exports.version = "18.3.0-canary-64f354cf2-20240306";
598598
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
599599
"function" ===
600600
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0066e0b68d90cc71a137f26b7c5bf6af73398fc2
1+
64f354cf27a17c4e5b0dfcd908e47940cf947771

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<195b02708667b43e1288d343dd8c9dea>>
10+
* @generated SignedSource<<90dcd25c986913250f107cd684f6e0bf>>
1111
*/
1212

1313
"use strict";
@@ -9216,7 +9216,7 @@ to return true:wantsResponderID| |
92169216
return null;
92179217
}
92189218

9219-
function mapRemainingChildren(returnFiber, currentFirstChild) {
9219+
function mapRemainingChildren(currentFirstChild) {
92209220
// Add the remaining children to a temporary map so that we can find them by
92219221
// keys quickly. Implicit (null) keys get added to this set with their index
92229222
// instead.
@@ -9996,7 +9996,7 @@ to return true:wantsResponderID| |
99969996
return resultingFirstChild;
99979997
} // Add all children to a key map for quick lookups.
99989998

9999-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
9999+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1000010000

1000110001
for (; newIdx < newChildren.length; newIdx++) {
1000210002
var _newFiber2 = updateFromMap(
@@ -10216,7 +10216,7 @@ to return true:wantsResponderID| |
1021610216
return resultingFirstChild;
1021710217
} // Add all children to a key map for quick lookups.
1021810218

10219-
var existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves.
10219+
var existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves.
1022010220

1022110221
for (; !step.done; newIdx++, step = newChildren.next()) {
1022210222
var _newFiber4 = updateFromMap(
@@ -28091,7 +28091,7 @@ to return true:wantsResponderID| |
2809128091
return root;
2809228092
}
2809328093

28094-
var ReactVersion = "18.3.0-canary-d679cfa2";
28094+
var ReactVersion = "18.3.0-canary-2c7f3036";
2809528095

2809628096
function createPortal$1(
2809728097
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<73b775dbdf05bc68c388e7bc468044de>>
10+
* @generated SignedSource<<85e0c72b2b7d0bd1bf1067ea7b661f79>>
1111
*/
1212

1313
"use strict";
@@ -2960,13 +2960,13 @@ function createChildReconciler(shouldTrackSideEffects) {
29602960
(currentFirstChild = currentFirstChild.sibling);
29612961
return null;
29622962
}
2963-
function mapRemainingChildren(returnFiber, currentFirstChild) {
2964-
for (returnFiber = new Map(); null !== currentFirstChild; )
2963+
function mapRemainingChildren(currentFirstChild) {
2964+
for (var existingChildren = new Map(); null !== currentFirstChild; )
29652965
null !== currentFirstChild.key
2966-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
2967-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
2966+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
2967+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
29682968
(currentFirstChild = currentFirstChild.sibling);
2969-
return returnFiber;
2969+
return existingChildren;
29702970
}
29712971
function useFiber(fiber, pendingProps) {
29722972
fiber = createWorkInProgress(fiber, pendingProps);
@@ -3315,7 +3315,7 @@ function createChildReconciler(shouldTrackSideEffects) {
33153315
return resultingFirstChild;
33163316
}
33173317
for (
3318-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3318+
oldFiber = mapRemainingChildren(oldFiber);
33193319
newIdx < newChildren.length;
33203320
newIdx++
33213321
)
@@ -3403,7 +3403,7 @@ function createChildReconciler(shouldTrackSideEffects) {
34033403
return iteratorFn;
34043404
}
34053405
for (
3406-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3406+
oldFiber = mapRemainingChildren(oldFiber);
34073407
!step.done;
34083408
newIdx++, step = newChildrenIterable.next()
34093409
)
@@ -9711,7 +9711,7 @@ var roots = new Map(),
97119711
devToolsConfig$jscomp$inline_1059 = {
97129712
findFiberByHostInstance: getInstanceFromNode,
97139713
bundleType: 0,
9714-
version: "18.3.0-canary-f799fa3f",
9714+
version: "18.3.0-canary-4fcd2209",
97159715
rendererPackageName: "react-native-renderer",
97169716
rendererConfig: {
97179717
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -9754,7 +9754,7 @@ var internals$jscomp$inline_1284 = {
97549754
scheduleRoot: null,
97559755
setRefreshHandler: null,
97569756
getCurrentFiber: null,
9757-
reconcilerVersion: "18.3.0-canary-f799fa3f"
9757+
reconcilerVersion: "18.3.0-canary-4fcd2209"
97589758
};
97599759
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97609760
var hook$jscomp$inline_1285 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bc533ae907b7c59bbe5b77cba5df8f95>>
10+
* @generated SignedSource<<cc71037d099328df481a42d35f756a4c>>
1111
*/
1212

1313
"use strict";
@@ -3085,13 +3085,13 @@ function createChildReconciler(shouldTrackSideEffects) {
30853085
(currentFirstChild = currentFirstChild.sibling);
30863086
return null;
30873087
}
3088-
function mapRemainingChildren(returnFiber, currentFirstChild) {
3089-
for (returnFiber = new Map(); null !== currentFirstChild; )
3088+
function mapRemainingChildren(currentFirstChild) {
3089+
for (var existingChildren = new Map(); null !== currentFirstChild; )
30903090
null !== currentFirstChild.key
3091-
? returnFiber.set(currentFirstChild.key, currentFirstChild)
3092-
: returnFiber.set(currentFirstChild.index, currentFirstChild),
3091+
? existingChildren.set(currentFirstChild.key, currentFirstChild)
3092+
: existingChildren.set(currentFirstChild.index, currentFirstChild),
30933093
(currentFirstChild = currentFirstChild.sibling);
3094-
return returnFiber;
3094+
return existingChildren;
30953095
}
30963096
function useFiber(fiber, pendingProps) {
30973097
fiber = createWorkInProgress(fiber, pendingProps);
@@ -3440,7 +3440,7 @@ function createChildReconciler(shouldTrackSideEffects) {
34403440
return resultingFirstChild;
34413441
}
34423442
for (
3443-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3443+
oldFiber = mapRemainingChildren(oldFiber);
34443444
newIdx < newChildren.length;
34453445
newIdx++
34463446
)
@@ -3528,7 +3528,7 @@ function createChildReconciler(shouldTrackSideEffects) {
35283528
return iteratorFn;
35293529
}
35303530
for (
3531-
oldFiber = mapRemainingChildren(returnFiber, oldFiber);
3531+
oldFiber = mapRemainingChildren(oldFiber);
35323532
!step.done;
35333533
newIdx++, step = newChildrenIterable.next()
35343534
)
@@ -10413,7 +10413,7 @@ var roots = new Map(),
1041310413
devToolsConfig$jscomp$inline_1137 = {
1041410414
findFiberByHostInstance: getInstanceFromNode,
1041510415
bundleType: 0,
10416-
version: "18.3.0-canary-3a92e945",
10416+
version: "18.3.0-canary-51750c0a",
1041710417
rendererPackageName: "react-native-renderer",
1041810418
rendererConfig: {
1041910419
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10469,7 +10469,7 @@ var roots = new Map(),
1046910469
scheduleRoot: null,
1047010470
setRefreshHandler: null,
1047110471
getCurrentFiber: null,
10472-
reconcilerVersion: "18.3.0-canary-3a92e945"
10472+
reconcilerVersion: "18.3.0-canary-51750c0a"
1047310473
});
1047410474
exports.createPortal = function (children, containerTag) {
1047510475
return createPortal$1(

0 commit comments

Comments
 (0)