From 355d677cfe9d44a28758981acd785ddf750ae89f Mon Sep 17 00:00:00 2001 From: sebmarkbage Date: Fri, 23 Feb 2024 20:21:51 +0000 Subject: [PATCH] Remove method name prefix from warnings and errors (#28432) This pattern is a petpeeve of mine. I don't consider this best practice and so most don't have these prefixes. Very inconsistent. At best this is useless and noisey that you have to parse because the information is also in the stack trace. At worse these are misleading because they're highlighting something internal (like validateDOMNesting) which even suggests an internal bug. Even the ones public to React aren't necessarily what you called because you might be calling a wrapper around it. That would be properly reflected in a stack trace - which can also properly ignore list so that the first stack you see is your callsite, Which might be like `render()` in react-testing-library rather than `createRoot()` for example. DiffTrain build for commit https://github.com/facebook/react/commit/d579e7748218920331252b0528850943d5e2dd31. --- .../cjs/ReactTestRenderer-dev.js | 31 +++++++------ .../cjs/ReactTestRenderer-prod.js | 4 +- .../cjs/ReactTestRenderer-profiling.js | 4 +- .../RKJSModules/vendor/react/cjs/React-dev.js | 12 +++--- .../vendor/react/cjs/React-prod.js | 10 ++--- .../vendor/react/cjs/React-profiling.js | 10 ++--- .../Libraries/Renderer/REVISION | 2 +- .../implementations/ReactFabric-dev.fb.js | 43 ++++++++----------- .../implementations/ReactFabric-prod.fb.js | 17 +++----- .../ReactFabric-profiling.fb.js | 17 +++----- .../ReactNativeRenderer-dev.fb.js | 43 ++++++++----------- .../ReactNativeRenderer-prod.fb.js | 17 +++----- .../ReactNativeRenderer-profiling.fb.js | 17 +++----- 13 files changed, 96 insertions(+), 131 deletions(-) diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js index d7add38913e8b..5571c2c4e2c19 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<20ec57c573e0a0a7a0d1a3309fa44b1b>> + * @generated SignedSource<> */ "use strict"; @@ -10966,21 +10966,20 @@ if (__DEV__) { Object.freeze(fakeInternalInstance); } - function warnOnInvalidCallback(callback, callerName) { + function warnOnInvalidCallback(callback) { { if (callback === null || typeof callback === "function") { return; - } + } // eslint-disable-next-line react-internal/safe-string-coercion - var key = callerName + "_" + callback; + var key = String(callback); if (!didWarnOnInvalidCallback.has(key)) { didWarnOnInvalidCallback.add(key); error( - "%s(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", - callerName, callback ); } @@ -11043,7 +11042,7 @@ if (__DEV__) { if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "setState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -11065,7 +11064,7 @@ if (__DEV__) { if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "replaceState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -11087,7 +11086,7 @@ if (__DEV__) { if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "forceUpdate"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -11152,13 +11151,13 @@ if (__DEV__) { if (!renderPresent) { if (ctor.prototype && typeof ctor.prototype.render === "function") { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: did you accidentally return an object from the constructor?", name ); } else { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: you may have forgotten to define `render`.", name ); @@ -11293,9 +11292,8 @@ if (__DEV__) { if (instance.props !== undefined && hasMutatedProps) { error( - "%s(...): When calling super() in `%s`, make sure to pass " + + "When calling super() in `%s`, make sure to pass " + "up the same props that your component's constructor was passed.", - name, name ); } @@ -13963,7 +13961,8 @@ if (__DEV__) { if (Component) { if (Component.childContextTypes) { error( - "%s(...): childContextTypes cannot be defined on a function component.", + "childContextTypes cannot be defined on a function component.\n" + + " %s.childContextTypes = ...", Component.displayName || Component.name || "Component" ); } @@ -25728,7 +25727,7 @@ if (__DEV__) { return root; } - var ReactVersion = "18.3.0-canary-8fb0233a8-20240223"; + var ReactVersion = "18.3.0-canary-d579e7748-20240223"; // Might add PROFILE later. @@ -25825,7 +25824,7 @@ if (__DEV__) { { if (typeof callback !== "function") { error( - "render(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", callback ); diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js index 683268c3b2184..da34da67d6005 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js @@ -9171,7 +9171,7 @@ var devToolsConfig$jscomp$inline_1014 = { throw Error("TestRenderer does not support findFiberByHostInstance()"); }, bundleType: 0, - version: "18.3.0-canary-8fb0233a8-20240223", + version: "18.3.0-canary-d579e7748-20240223", rendererPackageName: "react-test-renderer" }; var internals$jscomp$inline_1195 = { @@ -9202,7 +9202,7 @@ var internals$jscomp$inline_1195 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-8fb0233a8-20240223" + reconcilerVersion: "18.3.0-canary-d579e7748-20240223" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1196 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js index 61dc7ddb99479..d8a6fb3bf407c 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js @@ -9599,7 +9599,7 @@ var devToolsConfig$jscomp$inline_1056 = { throw Error("TestRenderer does not support findFiberByHostInstance()"); }, bundleType: 0, - version: "18.3.0-canary-8fb0233a8-20240223", + version: "18.3.0-canary-d579e7748-20240223", rendererPackageName: "react-test-renderer" }; var internals$jscomp$inline_1236 = { @@ -9630,7 +9630,7 @@ var internals$jscomp$inline_1236 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-8fb0233a8-20240223" + reconcilerVersion: "18.3.0-canary-d579e7748-20240223" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1237 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js index 8f118752b2243..527f247cfd877 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<0ecfa00d9e6316d213c0fcd6bd2fed34>> + * @generated SignedSource<<5829f9269f50c47e26af16e11355c71d>> */ "use strict"; @@ -26,7 +26,7 @@ if (__DEV__) { } var dynamicFlags = require("ReactNativeInternalFeatureFlags"); - var ReactVersion = "18.3.0-canary-8fb0233a8-20240223"; + var ReactVersion = "18.3.0-canary-d579e7748-20240223"; // ATTENTION // When adding new symbols to this file, @@ -383,7 +383,7 @@ if (__DEV__) { partialState != null ) { throw new Error( - "setState(...): takes an object of state variables to update or a " + + "takes an object of state variables to update or a " + "function which returns an object of state variables." ); } @@ -1885,7 +1885,7 @@ if (__DEV__) { function cloneElement(element, config, children) { if (element === null || element === undefined) { throw new Error( - "React.cloneElement(...): The argument must be a React element, but you passed " + + "The argument must be a React element, but you passed " + element + "." ); @@ -2806,7 +2806,7 @@ if (__DEV__) { // $FlowFixMe[missing-local-annot] set: function (newDefaultProps) { error( - "React.lazy(...): It is not supported to assign `defaultProps` to " + + "It is not supported to assign `defaultProps` to " + "a lazy component import. Either specify them where the component " + "is defined, or create a wrapping component around it." ); @@ -2827,7 +2827,7 @@ if (__DEV__) { // $FlowFixMe[missing-local-annot] set: function (newPropTypes) { error( - "React.lazy(...): It is not supported to assign `propTypes` to " + + "It is not supported to assign `propTypes` to " + "a lazy component import. Either specify them where the component " + "is defined, or create a wrapping component around it." ); diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js index 5f773c0beee7a..29101fbc8e58f 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<37f4ed7242b99027f4654904bb633f36>> + * @generated SignedSource<<0993517f18dba2ba924e7d54b3b13100>> */ "use strict"; @@ -61,7 +61,7 @@ Component.prototype.setState = function (partialState, callback) { null != partialState ) throw Error( - "setState(...): takes an object of state variables to update or a function which returns an object of state variables." + "takes an object of state variables to update or a function which returns an object of state variables." ); this.updater.enqueueSetState(this, partialState, callback, "setState"); }; @@ -422,9 +422,7 @@ exports.cache = function (fn) { exports.cloneElement = function (element, config, children) { if (null === element || void 0 === element) throw Error( - "React.cloneElement(...): The argument must be a React element, but you passed " + - element + - "." + "The argument must be a React element, but you passed " + element + "." ); var props = assign({}, element.props), key = element.key, @@ -600,4 +598,4 @@ exports.useSyncExternalStore = function ( exports.useTransition = function () { return ReactCurrentDispatcher.current.useTransition(); }; -exports.version = "18.3.0-canary-8fb0233a8-20240223"; +exports.version = "18.3.0-canary-d579e7748-20240223"; diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js index 4c5d386236a63..be559db8ca526 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js +++ b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<04ca2715fce5363a86317b200bb764c0>> + * @generated SignedSource<<0c357b236599560d718ddaa394fc28e0>> */ "use strict"; @@ -64,7 +64,7 @@ Component.prototype.setState = function (partialState, callback) { null != partialState ) throw Error( - "setState(...): takes an object of state variables to update or a function which returns an object of state variables." + "takes an object of state variables to update or a function which returns an object of state variables." ); this.updater.enqueueSetState(this, partialState, callback, "setState"); }; @@ -389,9 +389,7 @@ exports.cache = function (fn) { exports.cloneElement = function (element, config, children) { if (null === element || void 0 === element) throw Error( - "React.cloneElement(...): The argument must be a React element, but you passed " + - element + - "." + "The argument must be a React element, but you passed " + element + "." ); var props = assign({}, element.props), key = element.key, @@ -596,7 +594,7 @@ exports.useSyncExternalStore = function ( exports.useTransition = function () { return ReactCurrentDispatcher.current.useTransition(); }; -exports.version = "18.3.0-canary-8fb0233a8-20240223"; +exports.version = "18.3.0-canary-d579e7748-20240223"; "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ && "function" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop && diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION index 7520b6c5ac63b..007f153c5c692 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION @@ -1 +1 @@ -8fb0233a845974b4b1049e54b6c25dc54d6dd173 +d579e7748218920331252b0528850943d5e2dd31 diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js index 6017f2c312234..49a47c1d4a4d6 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<0fa268fef623a046bc40195fb725492a>> + * @generated SignedSource<<575cc3b40a7c3dee749cf6fb176a4449>> */ "use strict"; @@ -399,7 +399,7 @@ if (__DEV__) { { if (!getNodeFromInstance$1 || !getInstanceFromNode$1) { error( - "EventPluginUtils.setComponentTree(...): Injected " + + "Injected " + "module is missing getNodeFromInstance or getInstanceFromNode." ); } @@ -534,7 +534,7 @@ if (__DEV__) { var dispatchInstance = event._dispatchInstances; if (isArray(dispatchListener)) { - throw new Error("executeDirectDispatch(...): Invalid `event`."); + throw new Error("Invalid `event`."); } event.currentTarget = dispatchListener @@ -1160,9 +1160,7 @@ if (__DEV__) { function accumulate(current, next) { if (next == null) { - throw new Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw new Error("Accumulated items must not be null or undefined."); } if (current == null) { @@ -1200,9 +1198,7 @@ if (__DEV__) { function accumulateInto(current, next) { if (next == null) { - throw new Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw new Error("Accumulated items must not be null or undefined."); } if (current == null) { @@ -14182,21 +14178,20 @@ to return true:wantsResponderID| | Object.freeze(fakeInternalInstance); } - function warnOnInvalidCallback(callback, callerName) { + function warnOnInvalidCallback(callback) { { if (callback === null || typeof callback === "function") { return; - } + } // eslint-disable-next-line react-internal/safe-string-coercion - var key = callerName + "_" + callback; + var key = String(callback); if (!didWarnOnInvalidCallback.has(key)) { didWarnOnInvalidCallback.add(key); error( - "%s(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", - callerName, callback ); } @@ -14270,7 +14265,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "setState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14296,7 +14291,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "replaceState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14322,7 +14317,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "forceUpdate"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14406,13 +14401,13 @@ to return true:wantsResponderID| | if (!renderPresent) { if (ctor.prototype && typeof ctor.prototype.render === "function") { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: did you accidentally return an object from the constructor?", name ); } else { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: you may have forgotten to define `render`.", name ); @@ -14547,9 +14542,8 @@ to return true:wantsResponderID| | if (instance.props !== undefined && hasMutatedProps) { error( - "%s(...): When calling super() in `%s`, make sure to pass " + + "When calling super() in `%s`, make sure to pass " + "up the same props that your component's constructor was passed.", - name, name ); } @@ -17073,7 +17067,8 @@ to return true:wantsResponderID| | if (Component) { if (Component.childContextTypes) { error( - "%s(...): childContextTypes cannot be defined on a function component.", + "childContextTypes cannot be defined on a function component.\n" + + " %s.childContextTypes = ...", Component.displayName || Component.name || "Component" ); } @@ -28039,7 +28034,7 @@ to return true:wantsResponderID| | return root; } - var ReactVersion = "18.3.0-canary-868fc9ad"; + var ReactVersion = "18.3.0-canary-6032fc8f"; function createPortal$1( children, @@ -28236,7 +28231,7 @@ to return true:wantsResponderID| | { if (typeof callback !== "function") { error( - "render(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", callback ); diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js index b1934cf6f14cd..5c1231dd0e284 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<743b9976cf9cb1022780b5808cc05a13>> + * @generated SignedSource<> */ "use strict"; @@ -76,8 +76,7 @@ function executeDispatch(event, listener, inst) { function executeDirectDispatch(event) { var dispatchListener = event._dispatchListeners, dispatchInstance = event._dispatchInstances; - if (isArrayImpl(dispatchListener)) - throw Error("executeDirectDispatch(...): Invalid `event`."); + if (isArrayImpl(dispatchListener)) throw Error("Invalid `event`."); event.currentTarget = dispatchListener ? getNodeFromInstance$1(dispatchInstance) : null; @@ -336,9 +335,7 @@ var instrumentationCallback, }; function accumulate(current, next) { if (null == next) - throw Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); return null == current ? next : isArrayImpl(current) @@ -349,9 +346,7 @@ function accumulate(current, next) { } function accumulateInto(current, next) { if (null == next) - throw Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); if (null == current) return next; if (isArrayImpl(current)) { if (isArrayImpl(next)) return current.push.apply(current, next), current; @@ -9692,7 +9687,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1069 = { findFiberByHostInstance: getInstanceFromNode, bundleType: 0, - version: "18.3.0-canary-06019910", + version: "18.3.0-canary-def5fb42", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -9735,7 +9730,7 @@ var internals$jscomp$inline_1294 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-06019910" + reconcilerVersion: "18.3.0-canary-def5fb42" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1295 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js index e9b44ecb6057f..00fc05c28215e 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<<0350e17049e5f4e18145e2eb8636ec13>> */ "use strict"; @@ -80,8 +80,7 @@ function executeDispatch(event, listener, inst) { function executeDirectDispatch(event) { var dispatchListener = event._dispatchListeners, dispatchInstance = event._dispatchInstances; - if (isArrayImpl(dispatchListener)) - throw Error("executeDirectDispatch(...): Invalid `event`."); + if (isArrayImpl(dispatchListener)) throw Error("Invalid `event`."); event.currentTarget = dispatchListener ? getNodeFromInstance$1(dispatchInstance) : null; @@ -340,9 +339,7 @@ var instrumentationCallback, }; function accumulate(current, next) { if (null == next) - throw Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); return null == current ? next : isArrayImpl(current) @@ -353,9 +350,7 @@ function accumulate(current, next) { } function accumulateInto(current, next) { if (null == next) - throw Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); if (null == current) return next; if (isArrayImpl(current)) { if (isArrayImpl(next)) return current.push.apply(current, next), current; @@ -10390,7 +10385,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1147 = { findFiberByHostInstance: getInstanceFromNode, bundleType: 0, - version: "18.3.0-canary-9dda16fd", + version: "18.3.0-canary-ffa714ed", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -10446,7 +10441,7 @@ var roots = new Map(), scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-9dda16fd" + reconcilerVersion: "18.3.0-canary-ffa714ed" }); exports.createPortal = function (children, containerTag) { return createPortal$1( diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js index 24b06daac516e..ddc289adf931d 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<5be82410d05ff93f97b00ace398de099>> + * @generated SignedSource<<50e7f5f201ab5dea1513a63712db8d3a>> */ "use strict"; @@ -399,7 +399,7 @@ if (__DEV__) { { if (!getNodeFromInstance || !getInstanceFromNode) { error( - "EventPluginUtils.setComponentTree(...): Injected " + + "Injected " + "module is missing getNodeFromInstance or getInstanceFromNode." ); } @@ -534,7 +534,7 @@ if (__DEV__) { var dispatchInstance = event._dispatchInstances; if (isArray(dispatchListener)) { - throw new Error("executeDirectDispatch(...): Invalid `event`."); + throw new Error("Invalid `event`."); } event.currentTarget = dispatchListener @@ -1160,9 +1160,7 @@ if (__DEV__) { function accumulate(current, next) { if (next == null) { - throw new Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw new Error("Accumulated items must not be null or undefined."); } if (current == null) { @@ -1200,9 +1198,7 @@ if (__DEV__) { function accumulateInto(current, next) { if (next == null) { - throw new Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw new Error("Accumulated items must not be null or undefined."); } if (current == null) { @@ -14453,21 +14449,20 @@ to return true:wantsResponderID| | Object.freeze(fakeInternalInstance); } - function warnOnInvalidCallback(callback, callerName) { + function warnOnInvalidCallback(callback) { { if (callback === null || typeof callback === "function") { return; - } + } // eslint-disable-next-line react-internal/safe-string-coercion - var key = callerName + "_" + callback; + var key = String(callback); if (!didWarnOnInvalidCallback.has(key)) { didWarnOnInvalidCallback.add(key); error( - "%s(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", - callerName, callback ); } @@ -14541,7 +14536,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "setState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14567,7 +14562,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "replaceState"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14593,7 +14588,7 @@ to return true:wantsResponderID| | if (callback !== undefined && callback !== null) { { - warnOnInvalidCallback(callback, "forceUpdate"); + warnOnInvalidCallback(callback); } update.callback = callback; @@ -14677,13 +14672,13 @@ to return true:wantsResponderID| | if (!renderPresent) { if (ctor.prototype && typeof ctor.prototype.render === "function") { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: did you accidentally return an object from the constructor?", name ); } else { error( - "%s(...): No `render` method found on the returned component " + + "No `render` method found on the %s " + "instance: you may have forgotten to define `render`.", name ); @@ -14818,9 +14813,8 @@ to return true:wantsResponderID| | if (instance.props !== undefined && hasMutatedProps) { error( - "%s(...): When calling super() in `%s`, make sure to pass " + + "When calling super() in `%s`, make sure to pass " + "up the same props that your component's constructor was passed.", - name, name ); } @@ -17344,7 +17338,8 @@ to return true:wantsResponderID| | if (Component) { if (Component.childContextTypes) { error( - "%s(...): childContextTypes cannot be defined on a function component.", + "childContextTypes cannot be defined on a function component.\n" + + " %s.childContextTypes = ...", Component.displayName || Component.name || "Component" ); } @@ -28479,7 +28474,7 @@ to return true:wantsResponderID| | return root; } - var ReactVersion = "18.3.0-canary-0c89aec8"; + var ReactVersion = "18.3.0-canary-0d6ee362"; function createPortal$1( children, @@ -28676,7 +28671,7 @@ to return true:wantsResponderID| | { if (typeof callback !== "function") { error( - "render(...): Expected the last optional `callback` argument to be a " + + "Expected the last optional `callback` argument to be a " + "function. Instead received: %s.", callback ); diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js index 8881d5addb921..bd45d214c83ad 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<> + * @generated SignedSource<<812a9e09e3ae33fdba69074b3c4a6016>> */ "use strict"; @@ -76,8 +76,7 @@ function executeDispatch(event, listener, inst) { function executeDirectDispatch(event) { var dispatchListener = event._dispatchListeners, dispatchInstance = event._dispatchInstances; - if (isArrayImpl(dispatchListener)) - throw Error("executeDirectDispatch(...): Invalid `event`."); + if (isArrayImpl(dispatchListener)) throw Error("Invalid `event`."); event.currentTarget = dispatchListener ? getNodeFromInstance(dispatchInstance) : null; @@ -336,9 +335,7 @@ var instrumentationCallback, }; function accumulate(current, next) { if (null == next) - throw Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); return null == current ? next : isArrayImpl(current) @@ -349,9 +346,7 @@ function accumulate(current, next) { } function accumulateInto(current, next) { if (null == next) - throw Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); if (null == current) return next; if (isArrayImpl(current)) { if (isArrayImpl(next)) return current.push.apply(current, next), current; @@ -9910,7 +9905,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1138 = { findFiberByHostInstance: getInstanceFromTag, bundleType: 0, - version: "18.3.0-canary-82f6e470", + version: "18.3.0-canary-62437c9b", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -9953,7 +9948,7 @@ var internals$jscomp$inline_1377 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-82f6e470" + reconcilerVersion: "18.3.0-canary-62437c9b" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1378 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js index a5f8f57375ad3..fba7762465d2b 100644 --- a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js +++ b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js @@ -7,7 +7,7 @@ * @noflow * @nolint * @preventMunge - * @generated SignedSource<<38dfc1d1ad422291a111bb9d8399dcea>> + * @generated SignedSource<<507d660f60907c9b0d0c5b895716660f>> */ "use strict"; @@ -80,8 +80,7 @@ function executeDispatch(event, listener, inst) { function executeDirectDispatch(event) { var dispatchListener = event._dispatchListeners, dispatchInstance = event._dispatchInstances; - if (isArrayImpl(dispatchListener)) - throw Error("executeDirectDispatch(...): Invalid `event`."); + if (isArrayImpl(dispatchListener)) throw Error("Invalid `event`."); event.currentTarget = dispatchListener ? getNodeFromInstance(dispatchInstance) : null; @@ -340,9 +339,7 @@ var instrumentationCallback, }; function accumulate(current, next) { if (null == next) - throw Error( - "accumulate(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); return null == current ? next : isArrayImpl(current) @@ -353,9 +350,7 @@ function accumulate(current, next) { } function accumulateInto(current, next) { if (null == next) - throw Error( - "accumulateInto(...): Accumulated items must not be null or undefined." - ); + throw Error("Accumulated items must not be null or undefined."); if (null == current) return next; if (isArrayImpl(current)) { if (isArrayImpl(next)) return current.push.apply(current, next), current; @@ -10608,7 +10603,7 @@ var roots = new Map(), devToolsConfig$jscomp$inline_1216 = { findFiberByHostInstance: getInstanceFromTag, bundleType: 0, - version: "18.3.0-canary-82057a3e", + version: "18.3.0-canary-372089a1", rendererPackageName: "react-native-renderer", rendererConfig: { getInspectorDataForInstance: getInspectorDataForInstance, @@ -10664,7 +10659,7 @@ var roots = new Map(), scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-canary-82057a3e" + reconcilerVersion: "18.3.0-canary-372089a1" }); exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = { computeComponentStackForErrorReporting: function (reactTag) {