Skip to content

Commit 187dc16

Browse files
kassenskassens
committed
Performance: avoid triggering map deopt in V8 (#28569)
The shape of the objects changed by this PR are both created in 2 locations with 2 different shapes, which most JS engines won't like. I've noticed this in particular in V8 while benchmarking production code. https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberCacheComponent.js#L66-L77 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHostContext.js#L47-L54 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3530-L3531 https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3492-L3493 DiffTrain build for [4d686a2](4d686a2)
1 parent 0ef0a51 commit 187dc16

19 files changed

+97
-97
lines changed

‎compiled/facebook-www/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
38327309a4172a52cf94e8e264990bedafc1df6e
1+
4d686a2da138cad9e76c7de9feadd81ca2aa29e5

‎compiled/facebook-www/React-prod.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
633633
exports.useTransition = function () {
634634
return ReactCurrentDispatcher.current.useTransition();
635635
};
636-
exports.version = "18.3.0-www-classic-e323f09a";
636+
exports.version = "18.3.0-www-classic-a611e792";

‎compiled/facebook-www/React-profiling.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ exports.useSyncExternalStore = function (
637637
exports.useTransition = function () {
638638
return ReactCurrentDispatcher.current.useTransition();
639639
};
640-
exports.version = "18.3.0-www-classic-c2e666d0";
640+
exports.version = "18.3.0-www-classic-b0205e8a";
641641
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
642642
"function" ===
643643
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-40121660";
69+
var ReactVersion = "18.3.0-www-classic-7fbd8e77";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -3617,11 +3617,11 @@ if (__DEV__) {
36173617

36183618
var HostTransitionContext = {
36193619
$$typeof: REACT_CONTEXT_TYPE,
3620+
Provider: null,
3621+
Consumer: null,
36203622
_currentValue: null,
36213623
_currentValue2: null,
3622-
_threadCount: 0,
3623-
Provider: null,
3624-
Consumer: null
3624+
_threadCount: 0
36253625
};
36263626

36273627
function requiredContext(c) {
@@ -11192,8 +11192,8 @@ if (__DEV__) {
1119211192
useContext: throwInvalidHookError,
1119311193
useEffect: throwInvalidHookError,
1119411194
useImperativeHandle: throwInvalidHookError,
11195-
useInsertionEffect: throwInvalidHookError,
1119611195
useLayoutEffect: throwInvalidHookError,
11196+
useInsertionEffect: throwInvalidHookError,
1119711197
useMemo: throwInvalidHookError,
1119811198
useReducer: throwInvalidHookError,
1119911199
useRef: throwInvalidHookError,

‎compiled/facebook-www/ReactART-dev.modern.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-8be7683a";
69+
var ReactVersion = "18.3.0-www-modern-b0c54115";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -3382,11 +3382,11 @@ if (__DEV__) {
33823382

33833383
var HostTransitionContext = {
33843384
$$typeof: REACT_CONTEXT_TYPE,
3385+
Provider: null,
3386+
Consumer: null,
33853387
_currentValue: null,
33863388
_currentValue2: null,
3387-
_threadCount: 0,
3388-
Provider: null,
3389-
Consumer: null
3389+
_threadCount: 0
33903390
};
33913391

33923392
function requiredContext(c) {
@@ -10957,8 +10957,8 @@ if (__DEV__) {
1095710957
useContext: throwInvalidHookError,
1095810958
useEffect: throwInvalidHookError,
1095910959
useImperativeHandle: throwInvalidHookError,
10960-
useInsertionEffect: throwInvalidHookError,
1096110960
useLayoutEffect: throwInvalidHookError,
10961+
useInsertionEffect: throwInvalidHookError,
1096210962
useMemo: throwInvalidHookError,
1096310963
useReducer: throwInvalidHookError,
1096410964
useRef: throwInvalidHookError,

‎compiled/facebook-www/ReactART-prod.classic.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -931,11 +931,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
931931
hostTransitionProviderCursor = createCursor(null),
932932
HostTransitionContext = {
933933
$$typeof: REACT_CONTEXT_TYPE,
934+
Provider: null,
935+
Consumer: null,
934936
_currentValue: null,
935937
_currentValue2: null,
936-
_threadCount: 0,
937-
Provider: null,
938-
Consumer: null
938+
_threadCount: 0
939939
};
940940
function pushHostContainer(fiber, nextRootInstance) {
941941
push(rootInstanceStackCursor, nextRootInstance);
@@ -3524,8 +3524,8 @@ var ContextOnlyDispatcher = {
35243524
useContext: throwInvalidHookError,
35253525
useEffect: throwInvalidHookError,
35263526
useImperativeHandle: throwInvalidHookError,
3527-
useInsertionEffect: throwInvalidHookError,
35283527
useLayoutEffect: throwInvalidHookError,
3528+
useInsertionEffect: throwInvalidHookError,
35293529
useMemo: throwInvalidHookError,
35303530
useReducer: throwInvalidHookError,
35313531
useRef: throwInvalidHookError,
@@ -10626,7 +10626,7 @@ var slice = Array.prototype.slice,
1062610626
return null;
1062710627
},
1062810628
bundleType: 0,
10629-
version: "18.3.0-www-classic-0bce71b7",
10629+
version: "18.3.0-www-classic-4fbf3623",
1063010630
rendererPackageName: "react-art"
1063110631
};
1063210632
var internals$jscomp$inline_1320 = {
@@ -10657,7 +10657,7 @@ var internals$jscomp$inline_1320 = {
1065710657
scheduleRoot: null,
1065810658
setRefreshHandler: null,
1065910659
getCurrentFiber: null,
10660-
reconcilerVersion: "18.3.0-www-classic-0bce71b7"
10660+
reconcilerVersion: "18.3.0-www-classic-4fbf3623"
1066110661
};
1066210662
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1066310663
var hook$jscomp$inline_1321 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactART-prod.modern.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -727,11 +727,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
727727
hostTransitionProviderCursor = createCursor(null),
728728
HostTransitionContext = {
729729
$$typeof: REACT_CONTEXT_TYPE,
730+
Provider: null,
731+
Consumer: null,
730732
_currentValue: null,
731733
_currentValue2: null,
732-
_threadCount: 0,
733-
Provider: null,
734-
Consumer: null
734+
_threadCount: 0
735735
};
736736
function pushHostContainer(fiber, nextRootInstance) {
737737
push(rootInstanceStackCursor, nextRootInstance);
@@ -3320,8 +3320,8 @@ var ContextOnlyDispatcher = {
33203320
useContext: throwInvalidHookError,
33213321
useEffect: throwInvalidHookError,
33223322
useImperativeHandle: throwInvalidHookError,
3323-
useInsertionEffect: throwInvalidHookError,
33243323
useLayoutEffect: throwInvalidHookError,
3324+
useInsertionEffect: throwInvalidHookError,
33253325
useMemo: throwInvalidHookError,
33263326
useReducer: throwInvalidHookError,
33273327
useRef: throwInvalidHookError,
@@ -10281,7 +10281,7 @@ var slice = Array.prototype.slice,
1028110281
return null;
1028210282
},
1028310283
bundleType: 0,
10284-
version: "18.3.0-www-modern-1ea124ef",
10284+
version: "18.3.0-www-modern-3c5debba",
1028510285
rendererPackageName: "react-art"
1028610286
};
1028710287
var internals$jscomp$inline_1300 = {
@@ -10312,7 +10312,7 @@ var internals$jscomp$inline_1300 = {
1031210312
scheduleRoot: null,
1031310313
setRefreshHandler: null,
1031410314
getCurrentFiber: null,
10315-
reconcilerVersion: "18.3.0-www-modern-1ea124ef"
10315+
reconcilerVersion: "18.3.0-www-modern-3c5debba"
1031610316
};
1031710317
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1031810318
var hook$jscomp$inline_1301 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1130,11 +1130,11 @@ if (__DEV__) {
11301130

11311131
var HostTransitionContext = {
11321132
$$typeof: REACT_CONTEXT_TYPE,
1133+
Provider: null,
1134+
Consumer: null,
11331135
_currentValue: null,
11341136
_currentValue2: null,
1135-
_threadCount: 0,
1136-
Provider: null,
1137-
Consumer: null
1137+
_threadCount: 0
11381138
};
11391139

11401140
function requiredContext(c) {
@@ -16103,8 +16103,8 @@ if (__DEV__) {
1610316103
useContext: throwInvalidHookError,
1610416104
useEffect: throwInvalidHookError,
1610516105
useImperativeHandle: throwInvalidHookError,
16106-
useInsertionEffect: throwInvalidHookError,
1610716106
useLayoutEffect: throwInvalidHookError,
16107+
useInsertionEffect: throwInvalidHookError,
1610816108
useMemo: throwInvalidHookError,
1610916109
useReducer: throwInvalidHookError,
1611016110
useRef: throwInvalidHookError,
@@ -35785,7 +35785,7 @@ if (__DEV__) {
3578535785
return root;
3578635786
}
3578735787

35788-
var ReactVersion = "18.3.0-www-classic-4a0167db";
35788+
var ReactVersion = "18.3.0-www-classic-d282d81a";
3578935789

3579035790
function createPortal$1(
3579135791
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -325,11 +325,11 @@ if (__DEV__) {
325325

326326
var HostTransitionContext = {
327327
$$typeof: REACT_CONTEXT_TYPE,
328+
Provider: null,
329+
Consumer: null,
328330
_currentValue: null,
329331
_currentValue2: null,
330-
_threadCount: 0,
331-
Provider: null,
332-
Consumer: null
332+
_threadCount: 0
333333
};
334334

335335
function requiredContext(c) {
@@ -16065,8 +16065,8 @@ if (__DEV__) {
1606516065
useContext: throwInvalidHookError,
1606616066
useEffect: throwInvalidHookError,
1606716067
useImperativeHandle: throwInvalidHookError,
16068-
useInsertionEffect: throwInvalidHookError,
1606916068
useLayoutEffect: throwInvalidHookError,
16069+
useInsertionEffect: throwInvalidHookError,
1607016070
useMemo: throwInvalidHookError,
1607116071
useReducer: throwInvalidHookError,
1607216072
useRef: throwInvalidHookError,
@@ -35632,7 +35632,7 @@ if (__DEV__) {
3563235632
return root;
3563335633
}
3563435634

35635-
var ReactVersion = "18.3.0-www-modern-e747153f";
35635+
var ReactVersion = "18.3.0-www-modern-a7e0f9ae";
3563635636

3563735637
function createPortal$1(
3563835638
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,11 @@ var contextStackCursor$1 = createCursor(null),
380380
hostTransitionProviderCursor = createCursor(null),
381381
HostTransitionContext = {
382382
$$typeof: REACT_CONTEXT_TYPE,
383+
Provider: null,
384+
Consumer: null,
383385
_currentValue: null,
384386
_currentValue2: null,
385-
_threadCount: 0,
386-
Provider: null,
387-
Consumer: null
387+
_threadCount: 0
388388
};
389389
function pushHostContainer(fiber, nextRootInstance) {
390390
push(rootInstanceStackCursor, nextRootInstance);
@@ -4321,8 +4321,8 @@ var ContextOnlyDispatcher = {
43214321
useContext: throwInvalidHookError,
43224322
useEffect: throwInvalidHookError,
43234323
useImperativeHandle: throwInvalidHookError,
4324-
useInsertionEffect: throwInvalidHookError,
43254324
useLayoutEffect: throwInvalidHookError,
4325+
useInsertionEffect: throwInvalidHookError,
43264326
useMemo: throwInvalidHookError,
43274327
useReducer: throwInvalidHookError,
43284328
useRef: throwInvalidHookError,
@@ -17234,7 +17234,7 @@ Internals.Events = [
1723417234
var devToolsConfig$jscomp$inline_1817 = {
1723517235
findFiberByHostInstance: getClosestInstanceFromNode,
1723617236
bundleType: 0,
17237-
version: "18.3.0-www-classic-9a35a237",
17237+
version: "18.3.0-www-classic-28494f4a",
1723817238
rendererPackageName: "react-dom"
1723917239
};
1724017240
var internals$jscomp$inline_2176 = {
@@ -17264,7 +17264,7 @@ var internals$jscomp$inline_2176 = {
1726417264
scheduleRoot: null,
1726517265
setRefreshHandler: null,
1726617266
getCurrentFiber: null,
17267-
reconcilerVersion: "18.3.0-www-classic-9a35a237"
17267+
reconcilerVersion: "18.3.0-www-classic-28494f4a"
1726817268
};
1726917269
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1727017270
var hook$jscomp$inline_2177 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17595,4 +17595,4 @@ exports.useFormState = function (action, initialState, permalink) {
1759517595
exports.useFormStatus = function () {
1759617596
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1759717597
};
17598-
exports.version = "18.3.0-www-classic-9a35a237";
17598+
exports.version = "18.3.0-www-classic-28494f4a";

‎compiled/facebook-www/ReactDOM-prod.modern.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ var contextStackCursor = createCursor(null),
138138
hostTransitionProviderCursor = createCursor(null),
139139
HostTransitionContext = {
140140
$$typeof: REACT_CONTEXT_TYPE,
141+
Provider: null,
142+
Consumer: null,
141143
_currentValue: null,
142144
_currentValue2: null,
143-
_threadCount: 0,
144-
Provider: null,
145-
Consumer: null
145+
_threadCount: 0
146146
};
147147
function pushHostContainer(fiber, nextRootInstance) {
148148
push(rootInstanceStackCursor, nextRootInstance);
@@ -4215,8 +4215,8 @@ var ContextOnlyDispatcher = {
42154215
useContext: throwInvalidHookError,
42164216
useEffect: throwInvalidHookError,
42174217
useImperativeHandle: throwInvalidHookError,
4218-
useInsertionEffect: throwInvalidHookError,
42194218
useLayoutEffect: throwInvalidHookError,
4219+
useInsertionEffect: throwInvalidHookError,
42204220
useMemo: throwInvalidHookError,
42214221
useReducer: throwInvalidHookError,
42224222
useRef: throwInvalidHookError,
@@ -16750,7 +16750,7 @@ Internals.Events = [
1675016750
var devToolsConfig$jscomp$inline_1776 = {
1675116751
findFiberByHostInstance: getClosestInstanceFromNode,
1675216752
bundleType: 0,
16753-
version: "18.3.0-www-modern-50f5a0ca",
16753+
version: "18.3.0-www-modern-c2c97567",
1675416754
rendererPackageName: "react-dom"
1675516755
};
1675616756
var internals$jscomp$inline_2140 = {
@@ -16781,7 +16781,7 @@ var internals$jscomp$inline_2140 = {
1678116781
scheduleRoot: null,
1678216782
setRefreshHandler: null,
1678316783
getCurrentFiber: null,
16784-
reconcilerVersion: "18.3.0-www-modern-50f5a0ca"
16784+
reconcilerVersion: "18.3.0-www-modern-c2c97567"
1678516785
};
1678616786
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1678716787
var hook$jscomp$inline_2141 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17040,4 +17040,4 @@ exports.useFormState = function (action, initialState, permalink) {
1704017040
exports.useFormStatus = function () {
1704117041
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1704217042
};
17043-
exports.version = "18.3.0-www-modern-50f5a0ca";
17043+
exports.version = "18.3.0-www-modern-c2c97567";

‎compiled/facebook-www/ReactDOM-profiling.classic.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -385,11 +385,11 @@ var contextStackCursor$1 = createCursor(null),
385385
hostTransitionProviderCursor = createCursor(null),
386386
HostTransitionContext = {
387387
$$typeof: REACT_CONTEXT_TYPE,
388+
Provider: null,
389+
Consumer: null,
388390
_currentValue: null,
389391
_currentValue2: null,
390-
_threadCount: 0,
391-
Provider: null,
392-
Consumer: null
392+
_threadCount: 0
393393
};
394394
function pushHostContainer(fiber, nextRootInstance) {
395395
push(rootInstanceStackCursor, nextRootInstance);
@@ -4462,8 +4462,8 @@ var ContextOnlyDispatcher = {
44624462
useContext: throwInvalidHookError,
44634463
useEffect: throwInvalidHookError,
44644464
useImperativeHandle: throwInvalidHookError,
4465-
useInsertionEffect: throwInvalidHookError,
44664465
useLayoutEffect: throwInvalidHookError,
4466+
useInsertionEffect: throwInvalidHookError,
44674467
useMemo: throwInvalidHookError,
44684468
useReducer: throwInvalidHookError,
44694469
useRef: throwInvalidHookError,
@@ -17981,7 +17981,7 @@ Internals.Events = [
1798117981
var devToolsConfig$jscomp$inline_1902 = {
1798217982
findFiberByHostInstance: getClosestInstanceFromNode,
1798317983
bundleType: 0,
17984-
version: "18.3.0-www-classic-de998b54",
17984+
version: "18.3.0-www-classic-69241a16",
1798517985
rendererPackageName: "react-dom"
1798617986
};
1798717987
(function (internals) {
@@ -18025,7 +18025,7 @@ var devToolsConfig$jscomp$inline_1902 = {
1802518025
scheduleRoot: null,
1802618026
setRefreshHandler: null,
1802718027
getCurrentFiber: null,
18028-
reconcilerVersion: "18.3.0-www-classic-de998b54"
18028+
reconcilerVersion: "18.3.0-www-classic-69241a16"
1802918029
});
1803018030
assign(Internals, {
1803118031
ReactBrowserEventEmitter: {
@@ -18343,7 +18343,7 @@ exports.useFormState = function (action, initialState, permalink) {
1834318343
exports.useFormStatus = function () {
1834418344
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1834518345
};
18346-
exports.version = "18.3.0-www-classic-de998b54";
18346+
exports.version = "18.3.0-www-classic-69241a16";
1834718347
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1834818348
"function" ===
1834918349
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)