diff --git a/.eslintrc b/.eslintrc index 8c33d4d3842db6..d707517a0d6271 100644 --- a/.eslintrc +++ b/.eslintrc @@ -113,7 +113,6 @@ "no-caller": 1, // disallow use of arguments.caller or arguments.callee "no-div-regex": 1, // disallow division operators explicitly at beginning of regular expression (off by default) "no-else-return": 0, // disallow else after a return in an if (off by default) - "no-empty-label": 1, // disallow use of labels for anything other then loops and switches "no-eq-null": 0, // disallow comparisons to null without a type-checking operator (off by default) "no-eval": 1, // disallow use of eval() "no-extend-native": 1, // disallow adding to native types @@ -182,6 +181,8 @@ // These rules are purely matters of style and are quite subjective. "key-spacing": 0, + "keyword-spacing": 1, // enforce spacing before and after keywords + "jsx-quotes": [1, "prefer-double"], "comma-spacing": 0, "no-multi-spaces": 0, "brace-style": 0, // enforce one true brace style (off by default) @@ -205,11 +206,9 @@ "quote-props": 0, // require quotes around object literal property names (off by default) "semi": 1, // require or disallow use of semicolons instead of ASI "sort-vars": 0, // sort variables within the same declaration block (off by default) - "space-after-keywords": 1, // require a space after certain keywords (off by default) "space-in-brackets": 0, // require or disallow spaces inside brackets (off by default) "space-in-parens": 0, // require or disallow spaces inside parentheses (off by default) "space-infix-ops": 1, // require spaces around operators - "space-return-throw-case": 1, // require a space after return, throw, and case "space-unary-ops": [1, { "words": true, "nonwords": false }], // require or disallow spaces before/after unary operators (words on by default, nonwords off by default) "max-nested-callbacks": 0, // specify the maximum depth callbacks can be nested (off by default) "one-var": 0, // allow just one var statement per function (off by default) @@ -227,7 +226,6 @@ "react/display-name": 0, "react/jsx-boolean-value": 0, - "react/jsx-quotes": [1, "double", "avoid-escape"], "react/jsx-no-undef": 1, "react/jsx-sort-props": 0, "react/jsx-uses-react": 0, diff --git a/.travis.yml b/.travis.yml index a5ff66f5132fe7..184f0304f131f7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,7 +15,6 @@ install: - nvm install 5 - rm -Rf "${TMPDIR}/jest_preprocess_cache" - npm config set spin=false - - npm install -g flow-bin@`node -p "require('fs').readFileSync('.flowconfig', 'utf8').split('[version]')[1].trim()"` - npm install script: @@ -29,8 +28,8 @@ script: then npm install github@0.2.4 - cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; flow --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" node bots/code-analysis-bot.js - flow check && npm test -- '\/Libraries\/' + cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; npm run flow -- --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" node bots/code-analysis-bot.js + npm run flow -- check && npm test -- '\/Libraries\/' elif [ "$TEST_TYPE" = packager ] then diff --git a/package.json b/package.json index aadb2436f15461..0e47a7091bacc5 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,10 @@ "parse", "react-transform-hmr" ], - "platforms": ["ios", "android"] + "platforms": [ + "ios", + "android" + ] }, "modulePathIgnorePatterns": [ "/node_modules/(?!react|fbjs|react-native|parse|react-transform-hmr|core-js|promise)/", @@ -110,6 +113,7 @@ ], "scripts": { "test": "NODE_ENV=test jest", + "flow": "flow", "lint": "eslint Examples/ Libraries/", "start": "/usr/bin/env bash -c './packager/packager.sh \"$@\" || true' --" }, @@ -172,10 +176,11 @@ "yeoman-generator": "^0.20.3" }, "devDependencies": { + "babel-eslint": "^5.0.0", + "eslint": "^2.2.0", + "eslint-plugin-react": "^4.1.0", + "flow-bin": "^0.21.0", "jest-cli": "0.9.0-fb2", - "babel-eslint": "4.1.4", - "eslint": "1.3.1", - "eslint-plugin-react": "3.3.1", "portfinder": "0.4.0" } }