Fix flipped accessiblityState diffing #54574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Props 2.0 diffing had the old and new accessibilityState flipped in the HostPlatformViewProps implementation, which resulted in the disabled state output being flipped on change. Changelog: [Internal] Differential Revision: D87293652
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 936141f. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 936141f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Props 2.0 diffing had the old and new accessibilityState flipped in the HostPlatformViewProps implementation, which resulted in the disabled state output being flipped on change.
Changelog: [Internal]
Differential Revision: D87293652